Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report error when huggingface-cli is not available #719

Merged
merged 1 commit into from
Feb 3, 2025

Conversation

rhatdan
Copy link
Member

@rhatdan rhatdan commented Feb 3, 2025

Fixes: #688

Summary by Sourcery

Bug Fixes:

  • Report an error when huggingface-cli is unavailable when pushing or logging out.

Copy link
Contributor

sourcery-ai bot commented Feb 3, 2025

Reviewer's Guide by Sourcery

This pull request modifies the huggingface module to raise an exception when the huggingface-cli is not available, instead of skipping the operation or printing a message.

Sequence diagram for HuggingFace CLI operations with error handling

sequenceDiagram
    participant User
    participant HuggingFace

    alt huggingface-cli available
        User->>HuggingFace: login()/logout()/push()
        HuggingFace->>HuggingFace: Execute CLI command
        HuggingFace-->>User: Success
    else huggingface-cli not available
        User->>HuggingFace: login()/logout()/push()
        HuggingFace-->>User: Raise NotImplementedError
        Note over User,HuggingFace: Error: huggingface-cli not available
    end
Loading

File-Level Changes

Change Details Files
Raise an exception when huggingface-cli is not available.
  • Replaced NotImplementedError message with a variable missing_huggingface.
  • Removed print statement and return when hf_cli_available is false in push method.
  • Raise NotImplementedError with missing_huggingface when hf_cli_available is false in push method.
ramalama/huggingface.py

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @rhatdan - I've reviewed your changes - here's some feedback:

Overall Comments:

  • The missing_huggingface variable appears to be undefined. This needs to be defined before this change can work correctly.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@ericcurtin ericcurtin merged commit 9ab4d91 into containers:main Feb 3, 2025
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ramalama should detect if it is missing dependencies like huggingface_hub
2 participants