Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report error when huggingface-cli is not available #719

Merged
merged 1 commit into from
Feb 3, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions ramalama/huggingface.py
Original file line number Diff line number Diff line change
Expand Up @@ -45,15 +45,15 @@ def __init__(self, model):

def login(self, args):
if not self.hf_cli_available:
raise NotImplementedError("huggingface-cli not available, skipping login.")
raise NotImplementedError(missing_huggingface)
conman_args = ["huggingface-cli", "login"]
if args.token:
conman_args.extend(["--token", args.token])
self.exec(conman_args, args)

def logout(self, args):
if not self.hf_cli_available:
raise NotImplementedError("huggingface-cli not available, skipping logout.")
raise NotImplementedError(missing_huggingface)
conman_args = ["huggingface-cli", "logout"]
if args.token:
conman_args.extend(["--token", args.token])
Expand Down Expand Up @@ -124,8 +124,7 @@ def url_pull(self, args, model_path, directory_path):

def push(self, source, args):
if not self.hf_cli_available:
print("huggingface-cli not available, skipping push.")
return
raise NotImplementedError(missing_huggingface)
proc = run_cmd(
[
"huggingface-cli",
Expand Down
Loading