There would be one case where this wouldn't work

[ericcurtin]

When accumulated_size has just been refreshed to zero

Summary by Sourcery

Bug Fixes:

• Fix an edge case where the download progress was not being updated correctly when the total downloaded size was a multiple of the read buffer size.

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request addresses an edge case in the download progress update logic by introducing a new variable ('size') to handle scenarios where accumulated_size has been reset to zero. The change refactors the condition in the progress update check to rely on the new 'size' variable.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change	Details	Files
Introduce a new variable to correctly handle progress update checks after accumulated_size is reset.	Added a new variable 'size' initialized to 0 at the start of the download loop. Modified the condition in the progress update to check 'if size:' instead of 'if accumulated_size:' to handle the specific edge case.	ramalama/http_client.py

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!
• Generate a plan of action for an issue: Comment @sourcery-ai plan on
  an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @ericcurtin - I've reviewed your changes - here's some feedback:

Overall Comments:

• The final condition checks 'if size' but 'size' is never updated, suggesting an unintended switch from accumulated_size to size.

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[rhatdan]

This makes no sense, to add the option.

Why not do

if accumulated_size > 0:

You reset the accumalated_size option right after the do_final_progress.

[ericcurtin]

I'm trying to remember what I was fixing here. I'll change this to a one-liner:

if accumulated_size > 0:

like you suggested, although that shouldn't make a difference either.

[ericcurtin]

Ah it's the "\033[K" outside the if block that's the main fix...

I dislike python's indenting as '{' '}' sometimes, makes things like this not so obvious :)

[ericcurtin]

Wait sorry this does make sense... It's just not clear, I'll do it a different way that's more clear

[rhatdan]

So you can break out with if not data: when you have accumalated size and do not want to update_progress?

[rhatdan]

LGTM

Much better.

Merge when tests pass.