Hardening Redis db connectivity - #7
Conversation
Signed-off-by: Dawid Nowak <nowakd@gmail.com>
9fc2b9c to
26d151c
Compare
…vity Conflicts: Cargo.lock Cargo.toml Signed-off-by: Dawid Nowak <nowakd@gmail.com>
add9975 to
e3c982e
Compare
lucarlig
left a comment
lucarlig
left a comment
There was a problem hiding this comment.
Existing README and compose startup paths only pass Redis host/port. Add --redis-mode or CONTEXTFORGE_GATEWAY_RS_REDIS_CONNECTION_MODE there so documented launches still work.
If Redis TLS is intended, compose must use the TLS port and pass the trust bundle path. Otherwise the gateway fails config validation before connecting.
validate_certs() accepts empty files because it only checks parse errors. Ensure at least one certificate is parsed before returning Ok.
Signed-off-by: Dawid Nowak <nowakd@gmail.com>
lucarlig
left a comment
lucarlig
left a comment
There was a problem hiding this comment.
This is not directly in the PR diff, so I would not block this PR on it. But the PR’s new TLS default makes the existing per-operation Redis connection creation more expensive, especially on cache misses/writes. Worth opening a follow-up issue to consider reuse or pool Redis connections in RedisUserConfigStore.
Signed-off-by: Dawid Nowak <nowakd@gmail.com>
2 participants
No description provided.