-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce RAM usage #38
Reduce RAM usage #38
Conversation
I just made a few changes now since there are two of us and this is now in the cosmic-utils org. |
I think this has debug on correct? It seems to take a long time to make a repo and I can't close the ContextDrawer (right side menu) with the close button. |
Oh, we may need to close it in the new variant added to |
Alright, that should do it @ahoneybun |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and the about menu plus settings issue is gone now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the .metainfo.xml and .desktop files are renamed, the justfile needs to either not use APPID
or the app ID should be updated too or else just install
does not work:
Line 2 in 6f8339a
export APPID := 'com.github.ahoneybun.Stellarshot' |
<id>com.github.ahoneybun.Stellarshot</id> |
<launchable type="desktop-id">com.github.ahoneybun.Stellarshot.desktop</launchable> |
Perhaps SVGs should be renamed as well and the metainfo icon link updated to new canonical location?
Icon=com.github.ahoneybun.Stellarshot |
<icon type="remote" height="256" width="256">https://raw.githubusercontent.com/ahoneybun/Stellarshot/master/res/icons/hicolor/256x256/appscom.github.ahoneybun.Stellarshot.svg</icon> |
@lilyinstarlight thank you for catching that! I'm working in this PR to address that: |
This pull request updates libcosmic and it is expected to reduce the overall RAM usage of the program.