Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce RAM usage #38

Merged
merged 3 commits into from
Jan 11, 2025
Merged

Reduce RAM usage #38

merged 3 commits into from
Jan 11, 2025

Conversation

edfloreshz
Copy link
Member

This pull request updates libcosmic and it is expected to reduce the overall RAM usage of the program.

@edfloreshz edfloreshz requested a review from ahoneybun January 10, 2025 22:48
@ahoneybun
Copy link
Member

I just made a few changes now since there are two of us and this is now in the cosmic-utils org.

@ahoneybun
Copy link
Member

I think this has debug on correct? It seems to take a long time to make a repo and I can't close the ContextDrawer (right side menu) with the close button.

@edfloreshz
Copy link
Member Author

Oh, we may need to close it in the new variant added to Message

@edfloreshz
Copy link
Member Author

Alright, that should do it @ahoneybun

Copy link
Member

@ahoneybun ahoneybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and the about menu plus settings issue is gone now.

@ahoneybun ahoneybun merged commit 6f8339a into main Jan 11, 2025
1 check passed
@ahoneybun ahoneybun deleted the chore/update branch January 11, 2025 19:15

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the .metainfo.xml and .desktop files are renamed, the justfile needs to either not use APPID or the app ID should be updated too or else just install does not work:

export APPID := 'com.github.ahoneybun.Stellarshot'

<id>com.github.ahoneybun.Stellarshot</id>

<launchable type="desktop-id">com.github.ahoneybun.Stellarshot.desktop</launchable>

Perhaps SVGs should be renamed as well and the metainfo icon link updated to new canonical location?

Icon=com.github.ahoneybun.Stellarshot

<icon type="remote" height="256" width="256">https://raw.githubusercontent.com/ahoneybun/Stellarshot/master/res/icons/hicolor/256x256/appscom.github.ahoneybun.Stellarshot.svg</icon>

@ahoneybun ahoneybun mentioned this pull request Jan 13, 2025
@ahoneybun
Copy link
Member

@lilyinstarlight thank you for catching that! I'm working in this PR to address that:

#39

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants