Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix justfile #39

Merged
merged 10 commits into from
Jan 14, 2025
Merged

Fix justfile #39

merged 10 commits into from
Jan 14, 2025

Conversation

ahoneybun
Copy link
Member

This should address Lily's review from PR #38

@ahoneybun ahoneybun mentioned this pull request Jan 13, 2025
Merged
lilyinstarlight
lilyinstarlight reviewed Jan 14, 2025
View reviewed changes
Copy link

@lilyinstarlight lilyinstarlight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I finally got a chance to test and this does build correctly now after this change

Thanks you again for the quick turnaround! ❤️

@ahoneybun
Copy link
Member Author

I finally got a chance to test and this does build correctly now after this change

Thanks you again for the quick turnaround! ❤️

Thank you for the feedback and sorry that I missed it!

@ahoneybun ahoneybun merged commit ed916e4 into main Jan 14, 2025
1 check passed
@ahoneybun ahoneybun deleted the fix-justfile branch January 14, 2025 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lilyinstarlight lilyinstarlight lilyinstarlight left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahoneybun @lilyinstarlight