Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Managed HTTP Request Support in provider-http #7

Merged
merged 69 commits into from
Dec 13, 2023
Merged

Add Managed HTTP Request Support in provider-http #7

merged 69 commits into from
Dec 13, 2023

Conversation

arielsepton
Copy link
Member

Description

This PR adds a managable HTTP request to the provider-http, offering support for managing HTTP requests.

Changes Made

  • Implemented the Request Managed Resource to represent resources managed through http requests.
  • Developed functionality to send HTTP requests with configurable methods, headers, and bodies.
  • Included unit tests for crucial features.

Future Plans

As part of the project's future plans, I intend to enhance the capabilities of the provider-http for managing HTTP requests. Specifically:

  • Error Detection and Status Codes:

    • Introduce error detection mechanisms using JQ queries to identify errors in the response body.
    • Allow users to define an allow-list of HTTP status codes that determines whether a request is considered successful or a failure.

  • Method Mappings:

    • Explore the possibility of allowing multiple mappings for the same HTTP method, enabling more dynamic and versatile usage scenarios.

These planned enhancements aim to provide users with greater flexibility, improved error handling, and enhanced support for various scenarios in the management of HTTP requests.

@arielsepton arielsepton force-pushed the feature/http-managed-request branch 2 times, most recently from c559fa1 to 2521e38 Compare December 13, 2023 15:51
@arielsepton
# Initial commit for expanding provider-http to support managed HTTP …
db95d6c 
…requests.

This marks the start of adding managed HTTP requests support to provider-http.

- Added managed HTTP request foundation.

Signed-off-by: arielsepton <[email protected]>
@arielsepton
add request resource sample
1791e12 
Signed-off-by: arielsepton <[email protected]>
@arielsepton
add a base for request controller
b348f02 
Signed-off-by: arielsepton <[email protected]>
@arielsepton
add a base for observe function
0ae53ed 
Signed-off-by: arielsepton <[email protected]>
@arielsepton
add processing for mapping using gojq
f81ebac 
Signed-off-by: arielsepton <[email protected]>
@arielsepton
add desired state validation in observe function
5090d1b 
Signed-off-by: arielsepton <[email protected]>
@arielsepton
add handling for non existing resource
794eb9b 
Signed-off-by: arielsepton <[email protected]>
@arielsepton
add update conditions in observe func
16165e0 
Signed-off-by: arielsepton <[email protected]>
@arielsepton
make 'set_status.go more' flexible
950cd75 
Signed-off-by: arielsepton <[email protected]>
@arielsepton
remove func handleDeployActionError and instead reuse status setters
d10f72f 
Signed-off-by: arielsepton <[email protected]>
@arielsepton
remove code duplication of IsRequestValid functions
0299234 
Signed-off-by: arielsepton <[email protected]>
@arielsepton
remove code duplication of shouldRetry and waitTimeout functions
aa7795e 
Signed-off-by: arielsepton <[email protected]>
@arielsepton
separate to packages
c2a25ff 
Signed-off-by: arielsepton <[email protected]>
@arielsepton
remove TODO comment
30cb269 
Signed-off-by: arielsepton <[email protected]>
@arielsepton
implement all put and delete
5be5fea 
Signed-off-by: arielsepton <[email protected]>
@arielsepton
remove redundent variable
74dd934 
Signed-off-by: arielsepton <[email protected]>
@arielsepton
change mapping to jq query string instead of json
276555d 
Signed-off-by: arielsepton <[email protected]>
@arielsepton
add json utils package
d84aafb 
Signed-off-by: arielsepton <[email protected]>
@arielsepton
modify package name and add generateHeaders func
8490fa4 
Signed-off-by: arielsepton <[email protected]>
@arielsepton
beautify code and add loggers
2fc9c09 
Signed-off-by: arielsepton <[email protected]>
@arielsepton
modify file name and add ApplyJQOnMap func for headers
21f5431 
Signed-off-by: arielsepton <[email protected]>
@arielsepton
remove comment
cadf6dc 
Signed-off-by: arielsepton <[email protected]>
@arielsepton
modify file name from requestmapping to requestprocessing
83a3052 
Signed-off-by: arielsepton <[email protected]>
@arielsepton
add ParseMapStrings func
7285f29 
Signed-off-by: arielsepton <[email protected]>
@arielsepton
add ConvertJSONStringsToMaps func
0fbe411 
Signed-off-by: arielsepton <[email protected]>
@arielsepton
use generated headers in request.go
0001d75 
Signed-off-by: arielsepton <[email protected]>
@arielsepton
remove comment
db7670f 
Signed-off-by: arielsepton <[email protected]>
@arielsepton
add validation on mapping field
11e6f03 
Signed-off-by: arielsepton <[email protected]>
@arielsepton
add Cache support
d1d69c8 
Signed-off-by: arielsepton <[email protected]>
@arielsepton
add cache to request CRD
ee2ac15 
Signed-off-by: arielsepton <[email protected]>
@arielsepton
cache handling in request.go and modify utils
fb5e9db 
Signed-off-by: arielsepton <[email protected]>
@arielsepton
add comments for functions
b5b2b5b 
Signed-off-by: arielsepton <[email protected]>
@arielsepton
modify function
ff21d43 
Signed-off-by: arielsepton <[email protected]>
@arielsepton
fix isJsonString func
279c8ea 
Signed-off-by: arielsepton <[email protected]>
@arielsepton
handle non json responses
a4e765d 
Signed-off-by: arielsepton <[email protected]>
@arielsepton
improve shouldSetCache
139ea4d 
Signed-off-by: arielsepton <[email protected]>
@arielsepton
fix errors
34d5789 
Signed-off-by: arielsepton <[email protected]>
@arielsepton
add TODO
211f795 
Signed-off-by: arielsepton <[email protected]>
@arielsepton
remove redundent condition
98a010b 
Signed-off-by: arielsepton <[email protected]>
@arielsepton
add statushandler for Request
cd4ce59 
Signed-off-by: arielsepton <[email protected]>
@arielsepton
reset failures reset's error as well
5134100 
Signed-off-by: arielsepton <[email protected]>
@arielsepton
modify request's status handler
6da9483 
Signed-off-by: arielsepton <[email protected]>
@arielsepton
remove redundent retries check
72db2f8 
Signed-off-by: arielsepton <[email protected]>
@arielsepton
remove redundent retries check
563c738 
Signed-off-by: arielsepton <[email protected]>
@arielsepton
improve statusHandler
92fa013 
Signed-off-by: arielsepton <[email protected]>
@arielsepton
add unit tests and minor bug fixes
7fc0db4 
Signed-off-by: arielsepton <[email protected]>
@arielsepton
add unit tests and minor bug fixes
70e5cd6 
Signed-off-by: arielsepton <[email protected]>
@arielsepton
tests and minor code improvements
4f684ee 
Signed-off-by: arielsepton <[email protected]>
@arielsepton
Get the latest version of the resource before updating
7f85e10 
Signed-off-by: arielsepton <[email protected]>
@arielsepton
add skipTLSVerify
f79674d 
Signed-off-by: arielsepton <[email protected]>
@arielsepton
Get the latest version of the resource before updating
fce4cc2 
Signed-off-by: arielsepton <[email protected]>
@arielsepton
improve examples
be00131 
Signed-off-by: arielsepton <[email protected]>
@arielsepton
beautify client
3509a72 
Signed-off-by: arielsepton <[email protected]>
@arielsepton
update makefile and README
f552287 
Signed-off-by: arielsepton <[email protected]>
@arielsepton arielsepton force-pushed the feature/http-managed-request branch from 2521e38 to f552287 Compare December 13, 2023 15:57
@arielsepton arielsepton merged commit 3ca9f41 into crossplane-contrib:main Dec 13, 2023
7 checks passed
arielsepton added a commit to arielsepton/provider-http that referenced this pull request Feb 22, 2024
@arielsepton
Add Managed HTTP Request Support in provider-http (crossplane-contrib#7)
bd46e6f
arielsepton added a commit to arielsepton/provider-http that referenced this pull request Feb 22, 2024
@arielsepton
Add Managed HTTP Request Support in provider-http (crossplane-contrib#7)
cbed53f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@arielsepton