Add Managed HTTP Request Support in provider-http

Makefile

@@ -90,7 +90,8 @@ CROSSPLANE_NAMESPACE = crossplane-system
 -include build/makelib/local.xpkg.mk
 -include build/makelib/controlplane.mk
 
-UPTEST_EXAMPLE_LIST ?= "examples/sample/desposiblerequest.yaml"
+UPTEST_EXAMPLE_LIST := $(shell find ./examples/sample -path '*.yaml' | paste -s -d ',' - )
+
 uptest: $(UPTEST) $(KUBECTL) $(KUTTL)
 	@$(INFO) running automated tests
 	@KUBECTL=$(KUBECTL) KUTTL=$(KUTTL) $(UPTEST) e2e "$(UPTEST_EXAMPLE_LIST)" --setup-script=cluster/test/setup.sh || $(FAIL)

README.md

@@ -1,40 +1,76 @@
 # provider-http
 
-`provider-http` is a Crossplane Provider that enables sending one-time HTTP requests as disposable resources.
+`provider-http` is a Crossplane Provider designed to facilitate sending HTTP requests as resources.
+
 
 ## Installation
 
-If you would like to install `provider-http` without modifications, you can use the Crossplane CLI in a Kubernetes cluster where Crossplane is installed:
+To install `provider-http`, you have two options:
 
-```console
-kubectl crossplane install provider crossplanecontrib/provider-http:master
-```
+1. Using the Crossplane CLI in a Kubernetes cluster where Crossplane is installed:
+
+    ```console
+    kubectl crossplane install provider ghcr.io/arielsepton/provider-http:v1.2.0
+    ```
+
+2. Manually creating a Provider by applying the following YAML:
+
+    ```yaml
+    apiVersion: pkg.crossplane.io/v1
+    kind: Provider
+    metadata:
+      name: provider-http
+    spec:
+      package: "ghcr.io/arielsepton/provider-http:v1.2.0"
+    ```
+
+
+## Supported Resources
+
+`provider-http` supports the following resources:
+
+- **DisposableRequest:** Initiates a one-time HTTP request. See [DisposableRequest CRD documentation](resources-docs/desposiblerequest_docs.md).
+- **Request:** Manages a resource through HTTP requests. See [Request CRD documentation](resources-docs/request_docs.md).
+
+## Usage
 
-You can also manually install `provider-http` by creating a Provider directly:
+### DisposableRequest
+
+Create a `DisposableRequest` resource to initiate a single-use HTTP interaction:
 
 ```yaml
-apiVersion: pkg.crossplane.io/v1
-kind: Provider
+apiVersion: http.crossplane.io/v1alpha1
+kind: DisposableRequest
 metadata:
-  name: provider-http
+  name: example-disposable-request
 spec:
-  package: "crossplanecontrib/provider-http:master"
+  # Add your DisposableRequest specification here
 ```
+For more detailed examples and configuration options, refer to the [examples directory](examples/sample/).
 
-## Usage
 
-Currently, `provider-http` supports only one-time requests using the `DisposableRequest` Custom Resource Definition (CRD). This enables you to initiate a single-use HTTP interaction by creating a `DisposableRequest` resource.
+### Request
 
-## Developing locally
+Manage a resource through HTTP requests with a `Request` resource:
 
-Run controller against the cluster:
+```yaml
+apiVersion: http.crossplane.io/v1alpha1
+kind: Request
+metadata:
+  name: example-request
+spec:
+  # Add your Request specification here
+```
+For more detailed examples and configuration options, refer to the [examples directory](examples/sample/).
+
+
+### Developing locally
 
+Run controller against the cluster:
 ```
 make run
 ```
 
-Now you can create `DesposibleRequest` resources with provider reference, see [sample desposiblerequest.yaml](examples/sample/desposiblerequest.yaml).
 
-    ```
-    kubectl create -f examples/sample/desposiblerequest.yaml
-    ```
+### Troubleshooting
+If you encounter any issues during installation or usage, refer to the [troubleshooting guide](https://docs.crossplane.io/knowledge-base/guides/troubleshoot/) for common problems and solutions.

apis/desposiblerequest/v1alpha1/desposiblerequest_types.go

@@ -27,30 +27,31 @@ import (
 
 // DesposibleRequestParameters are the configurable fields of a DesposibleRequest.
 type DesposibleRequestParameters struct {
-	URL         string              `json:"url"`
-	Method      string              `json:"method"`
-	Headers     map[string][]string `json:"headers,omitempty"`
-	Body        string              `json:"body,omitempty"`
-	WaitTimeout *metav1.Duration    `json:"waitTimeout,omitempty"`
+	// +kubebuilder:validation:XValidation:rule="self == oldSelf",message="Field 'forProvider.url' is immutable"
+	URL string `json:"url"`
+	// +kubebuilder:validation:XValidation:rule="self == oldSelf",message="Field 'forProvider.method' is immutable"
+	Method string `json:"method"`
+	// +kubebuilder:validation:XValidation:rule="self == oldSelf",message="Field 'forProvider.headers' is immutable"
+	Headers map[string][]string `json:"headers,omitempty"`
+	// +kubebuilder:validation:XValidation:rule="self == oldSelf",message="Field 'forProvider.body' is immutable"
+	Body string `json:"body,omitempty"`
+
+	WaitTimeout *metav1.Duration `json:"waitTimeout,omitempty"`
 
 	// RollbackRetriesLimit is max number of attempts to retry HTTP request by sending again the request.
 	RollbackRetriesLimit *int32 `json:"rollbackLimit,omitempty"`
-}
 
-// DesposibleRequestObservation are the observable fields of a DesposibleRequest.
-type DesposibleRequestObservation struct {
-	ObservableField string `json:"observableField,omitempty"`
+	// InsecureSkipTLSVerify, when set to true, skips TLS certificate checks for the HTTP request
+	InsecureSkipTLSVerify bool `json:"insecureSkipTLSVerify,omitempty"`
 }
 
 // A DesposibleRequestSpec defines the desired state of a DesposibleRequest.
 type DesposibleRequestSpec struct {
 	xpv1.ResourceSpec `json:",inline"`
 
-	// +kubebuilder:validation:XValidation:rule="self == oldSelf",message="Field 'ForProvider' is immutable"
 	ForProvider DesposibleRequestParameters `json:"forProvider"`
 }
 
-// DesposibleRequestObservation are the observable fields of a DesposibleRequest.
 type Response struct {
 	StatusCode int                 `json:"statusCode,omitempty"`
 	Body       string              `json:"body,omitempty"`
@@ -60,11 +61,10 @@ type Response struct {
 // A DesposibleRequestStatus represents the observed state of a DesposibleRequest.
 type DesposibleRequestStatus struct {
 	xpv1.ResourceStatus `json:",inline"`
-	AtProvider          DesposibleRequestObservation `json:"atProvider,omitempty"`
-	Response            Response                     `json:"response,omitempty"`
-	Failed              int32                        `json:"failed,omitempty"`
-	Error               string                       `json:"error,omitempty"`
-	Synced              bool                         `json:"synced,omitempty"`
+	Response            Response `json:"response,omitempty"`
+	Failed              int32    `json:"failed,omitempty"`
+	Error               string   `json:"error,omitempty"`
+	Synced              bool     `json:"synced,omitempty"`
 }
 
 // +kubebuilder:object:root=true

apis/desposiblerequest/v1alpha1/status_setters.go

@@ -0,0 +1,25 @@
+package v1alpha1
+
+func (d *DesposibleRequest) SetStatusCode(statusCode int) {
+	d.Status.Response.StatusCode = statusCode
+}
+
+func (d *DesposibleRequest) SetHeaders(headers map[string][]string) {
+	d.Status.Response.Headers = headers
+}
+
+func (d *DesposibleRequest) SetBody(body string) {
+	d.Status.Response.Body = body
+}
+
+func (d *DesposibleRequest) SetSynced(synced bool) {
+	d.Status.Synced = synced
+}
+
+func (d *DesposibleRequest) SetError(err error) {
+	d.Status.Failed++
+	d.SetSynced(true)
+	if err != nil {
+		d.Status.Error = err.Error()
+	}
+}

apis/http.go

@@ -20,15 +20,17 @@ package apis
 import (
 	"k8s.io/apimachinery/pkg/runtime"
 
-	samplev1alpha1 "github.com/arielsepton/provider-http/apis/desposiblerequest/v1alpha1"
+	desposiblerequestv1alpha1 "github.com/arielsepton/provider-http/apis/desposiblerequest/v1alpha1"
+	requestv1alpha1 "github.com/arielsepton/provider-http/apis/request/v1alpha1"
 	httpv1alpha1 "github.com/arielsepton/provider-http/apis/v1alpha1"
 )
 
 func init() {
 	// Register the types with the Scheme so the components can map objects to GroupVersionKinds and back
 	AddToSchemes = append(AddToSchemes,
 		httpv1alpha1.SchemeBuilder.AddToScheme,
-		samplev1alpha1.SchemeBuilder.AddToScheme,
+		desposiblerequestv1alpha1.SchemeBuilder.AddToScheme,
+		requestv1alpha1.SchemeBuilder.AddToScheme,
 	)
 }
 

apis/request/request.go

@@ -0,0 +1,18 @@
+/*
+Copyright 2022 The Crossplane Authors.
+
+Licensed under the Apache License, Version 2.0 (the "License");
+you may not use this file except in compliance with the License.
+You may obtain a copy of the License at
+
+    http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+*/
+
+// Package request contains group request API versions
+package request

apis/request/v1alpha1/doc.go

@@ -0,0 +1,17 @@
+/*
+Copyright 2022 The Crossplane Authors.
+
+Licensed under the Apache License, Version 2.0 (the "License");
+you may not use this file except in compliance with the License.
+You may obtain a copy of the License at
+
+    http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+*/
+
+package v1alpha1

apis/request/v1alpha1/groupversion_info.go

@@ -0,0 +1,40 @@
+/*
+Copyright 2020 The Crossplane Authors.
+
+Licensed under the Apache License, Version 2.0 (the "License");
+you may not use this file except in compliance with the License.
+You may obtain a copy of the License at
+
+    http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+*/
+
+// Package v1alpha1 contains the v1alpha1 group Sample resources of the http provider.
+// +kubebuilder:object:generate=true
+// +groupName=http.crossplane.io
+// +versionName=v1alpha1
+package v1alpha1
+
+import (
+	"k8s.io/apimachinery/pkg/runtime/schema"
+	"sigs.k8s.io/controller-runtime/pkg/scheme"
+)
+
+// Package type metadata.
+const (
+	Group   = "http.crossplane.io"
+	Version = "v1alpha1"
+)
+
+var (
+	// SchemeGroupVersion is group version used to register these objects
+	SchemeGroupVersion = schema.GroupVersion{Group: Group, Version: Version}
+
+	// SchemeBuilder is used to add go types to the GroupVersionKind scheme
+	SchemeBuilder = &scheme.Builder{GroupVersion: SchemeGroupVersion}
+)