Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix role conversion #5071

Merged
merged 1 commit into from
Feb 5, 2025
Merged

Fix role conversion #5071

merged 1 commit into from
Feb 5, 2025

Conversation

bastianbeier
Copy link

Fix role from resource permission conversion

@bastianbeier bastianbeier self-assigned this Feb 5, 2025
@bastianbeier bastianbeier requested review from labkode, glpatcern and a team as code owners February 5, 2025 14:13
kobergj
kobergj reviewed Feb 5, 2025
View reviewed changes
Copy link
Contributor

@kobergj kobergj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@2403905 you mentioned we don't need this at all. Should we put it in anyways and clean it up later? I'm not entirely sure it won't break something....

@bastianbeier bastianbeier mentioned this pull request Feb 5, 2025
Merged
@2403905
Copy link

2403905 commented Feb 5, 2025

lets keep it.

@2403905 2403905 merged commit 2a7145a into cs3org:edge Feb 5, 2025
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kobergj kobergj kobergj left review comments

@2403905 2403905 2403905 approved these changes

@labkode labkode Awaiting requested review from labkode labkode is a code owner

@glpatcern glpatcern Awaiting requested review from glpatcern glpatcern is a code owner

Assignees

@bastianbeier bastianbeier

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bastianbeier @2403905 @kobergj