Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to most recent array-api commit #208

Closed
wants to merge 3 commits into from
Closed

Update to most recent array-api commit #208

wants to merge 3 commits into from

Conversation

jakevdp
Copy link
Contributor

@jakevdp jakevdp commented Nov 15, 2023

No description provided.

rgommers
rgommers approved these changes Nov 15, 2023
View reviewed changes
Copy link
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll leave this to @honno or @asmeurer to merge, but LGTM. Thanks again @jakevdp!

array_api_tests/dtype_helpers.py Outdated Show resolved Hide resolved
@honno honno linked an issue Nov 15, 2023 that may be closed by this pull request
Bump array-api submodule #187
Closed
honno
honno requested changes Nov 15, 2023
View reviewed changes
Copy link
Member

@honno honno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. Unfortunately updating the submodule breaks how we generate tests for special cases (and probably other things), so will take a look myself.

@kgryte kgryte mentioned this pull request Nov 15, 2023
Merged
@honno honno mentioned this pull request Nov 17, 2023
Merged
@honno
Copy link
Member

honno commented Nov 23, 2023

Closing as addressed in #213, which uses the work here—thanks again @jakevdp and let me know if this sorts out data-apis/array-api#631

@honno honno closed this Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte kgryte left review comments

@honno honno honno requested changes

@rgommers rgommers rgommers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bump array-api submodule
4 participants
@jakevdp @honno @rgommers @kgryte