Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in input data type for conj specification #706

Merged
merged 1 commit into from
Nov 16, 2023

Conversation

kgryte
Copy link
Contributor

@kgryte kgryte commented Nov 15, 2023

This PR

  • fixes a typo for the input data type in the conj specification. Currently, the hyphen is misplaced, and this PR corrects that mistake. This mistake was identified in Update to most recent array-api commit array-api-tests#208 (comment), requiring an undesired workaround in the test suite which attempts to use pattern matching for deriving test strategies.
  • backports the typo correction to the 2022.12 specification release in which conj was added to the specification.

@kgryte kgryte added Maintenance Bug fix, typo fix, or general maintenance. Backport Changes involve backporting to previous versions. labels Nov 15, 2023
@kgryte kgryte added this to the v2023 milestone Nov 15, 2023
Copy link
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kgryte

@rgommers rgommers merged commit ab69aa2 into data-apis:main Nov 16, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backport Changes involve backporting to previous versions. Maintenance Bug fix, typo fix, or general maintenance.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants