⚡ Bolt: Use short-circuiting for Qobuz secret testing#46
Draft
davidjuarezdev wants to merge 1 commit intomainfrom
Draft
⚡ Bolt: Use short-circuiting for Qobuz secret testing#46davidjuarezdev wants to merge 1 commit intomainfrom
davidjuarezdev wants to merge 1 commit intomainfrom
Conversation
Co-authored-by: davidjuarezdev <230496599+davidjuarezdev@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 What: Replaced
asyncio.gatherwithasyncio.as_completedwhen evaluating multiple potential Qobuz app secrets concurrently, actively cancelling any remaining pending requests once a valid secret is found.🎯 Why:
asyncio.gatherwaits for all background requests to resolve before execution resumes. When we only need the first successful match (e.g., when trying a list of potentially outdated or correct auth tokens), waiting for the rest is purely wasted latency and I/O.📊 Impact: Considerably faster initial authentication sequence for Qobuz since it immediately returns when a working app secret is found rather than waiting for slow failing responses, saving up to ~2-3 seconds of initialization latency. It also reduces completely unnecessary network pressure.
🔬 Measurement: Verify tests run fine and no unexpected errors are raised. Check Qobuz client initialization time.
PR created automatically by Jules for task 12533860873228520935 started by @davidjuarezdev