Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .jules/bolt.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,3 +5,6 @@
## 2026-03-20 - Non-blocking I/O in Deezer client
**Learning:** `streamrip/client/deezer.py` uses the synchronous `deezer-python` library. Direct calls like `client.gw.get_track()` and `client.get_track_url()` block the entire `asyncio` event loop. While the metadata fetching methods (`get_track`, `get_album`, etc.) correctly wrapped these calls in `await asyncio.to_thread(...)`, `get_downloadable` missed this, causing heavy blocking during concurrent downloads.
**Action:** Ensure all synchronous third-party API calls in async methods are wrapped with `await asyncio.to_thread(...)`.
## 2025-03-20 - Non-blocking concurrent requests with asyncio.as_completed
**Learning:** In `streamrip/client/qobuz.py`, when testing a list of potential app secrets, `asyncio.gather` was used, which waits for *all* test requests to complete before returning the first valid secret. By migrating to `asyncio.as_completed`, the application can short-circuit the network I/O validation process and cancel the remaining pending requests as soon as the first valid secret is found. This saves time and avoids unnecessary network calls.
**Action:** Prefer `asyncio.as_completed` over `asyncio.gather` for concurrent requests when only the first successful response is needed, ensuring to cancel any pending tasks to free up resources.
18 changes: 11 additions & 7 deletions streamrip/client/qobuz.py
Original file line number Diff line number Diff line change
Expand Up @@ -409,14 +409,18 @@ async def _test_secret(self, secret: str) -> Optional[str]:
return None

async def _get_valid_secret(self, secrets: list[str]) -> str:
results = await asyncio.gather(
*[self._test_secret(secret) for secret in secrets],
)
working_secrets = [r for r in results if r is not None]
if len(working_secrets) == 0:
raise InvalidAppSecretError(secrets)
tasks = [asyncio.create_task(self._test_secret(secret)) for secret in secrets]
try:
for future in asyncio.as_completed(tasks):
result = await future
if result is not None:
return result

return working_secrets[0]
raise InvalidAppSecretError(secrets)
finally:
for task in tasks:
if not task.done():
task.cancel()

async def _request_file_url(
self,
Expand Down