-
Notifications
You must be signed in to change notification settings - Fork 2
chore(core): add d8v prefix for more containers #1536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
diafour
wants to merge
2
commits into
main
Choose a base branch
from
chore/core/cdi-more-d8v-prefixed-containers
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+4
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Rename more containers for checkings in strict environment. - Fix container names in recording rules. Signed-off-by: Ivan Mikheykin <[email protected]>
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR prefixes core container image references with “d8v” and updates related recording rule definitions so that strict-environment checks recognize the new names. Class diagram for updated container image reference structureclassDiagram
class Core {
+3p-kubevirt: string
+3p-containerized-data-importer: string
+distribution: string
}
Core : 3p-containerized-data-importer = "dvp/chore/more-d8v-prefixed-containers"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Rename more containers for checkings in strict environment. - Fix container names in recording rules. - Add readonlyRootFilesystem=true for install strategy Jobs in kubevirt. Signed-off-by: Ivan Mikheykin <[email protected]>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Why do we need it, and what problem does it solve?
These containers should be checked in strict environments.
What is the expected result?
Checklist
Changelog entries