Skip to content

Conversation

diafour
Copy link
Member

@diafour diafour commented Oct 6, 2025

Description

  • Rename more containers for checkings in strict environment.
  • Fix container names in recording rules.

Why do we need it, and what problem does it solve?

These containers should be checked in strict environments.

What is the expected result?

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

Changelog entries

section: core
type: chore
summary: Strict environment should check containers for importer and upload-server pods.

- Rename more containers for checkings in strict environment.
- Fix container names in recording rules.

Signed-off-by: Ivan Mikheykin <[email protected]>
@diafour diafour requested review from fl64 and Isteb4k as code owners October 6, 2025 14:13
Copy link

sourcery-ai bot commented Oct 6, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR prefixes core container image references with “d8v” and updates related recording rule definitions so that strict-environment checks recognize the new names.

Class diagram for updated container image reference structure

classDiagram
  class Core {
    +3p-kubevirt: string
    +3p-containerized-data-importer: string
    +distribution: string
  }
  Core : 3p-containerized-data-importer = "dvp/chore/more-d8v-prefixed-containers"
Loading

File-Level Changes

Change Details Files
Prefix the containerized-data-importer image reference
  • Comment out the old 3p-containerized-data-importer tag
  • Add a new 3p-containerized-data-importer entry with the d8v-prefixed branch
build/components/versions.yml
Update container names in recording rules
  • Rename importer pod container references to include d8v prefix
  • Rename upload-server container labels accordingly
build/monitoring/recording_rules.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@diafour diafour added this to the v1.2.0 milestone Oct 6, 2025
- Rename more containers for checkings in strict environment.
- Fix container names in recording rules.
- Add readonlyRootFilesystem=true for install strategy Jobs in kubevirt.

Signed-off-by: Ivan Mikheykin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant