fix(minimax): align request body with selected transport#2705
Open
rixzkiye wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
reasoning_contentinto Anthropic Messages requestsProblem
MiniMax-M3 declares Claude as its target format. For OpenAI-format clients, transport selection previously used client source format while translation used model target format. This could send an Anthropic-shaped body and tool schema to MiniMax Chat Completions, causing
400 invalid tool typeresponses.Verification
cd tests && npx vitest run unit/minimax-transport-protocol.test.js unit/reasoningContentInjector.test.js unit/openai-to-claude-tools-no-type.test.js— 22 tests passednpx eslint open-sse/executors/default.js open-sse/handlers/chatCore.js open-sse/services/provider.js tests/unit/minimax-transport-protocol.test.jsgit diff --check origin/master...HEADNo live MiniMax credentials were used; protocol behavior is covered with focused unit tests.
Related issues
Fixes #1939
Fixes #2435
Fixes #2509