Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix JSONConverter to properly skip files that are not utf-8 encoded #8775

Merged
merged 6 commits into from
Jan 28, 2025

Conversation

sjrl
Copy link
Contributor

@sjrl sjrl commented Jan 27, 2025

Related Issues

  • fixes #issue-number

Proposed Changes:

A return statement was missing to properly skip JSON files that were detected to not be utf-8 encoded. I made the fix and added a test to check the behavior.

How did you test it?

I added a test.

Notes for the reviewer

Checklist

  • I have read the contributors guidelines and the code of conduct
  • I have updated the related issue with new insights and changes
  • I added unit tests and updated the docstrings
  • I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test: and added ! in case the PR includes breaking changes.
  • I documented my code
  • I ran pre-commit hooks and fixed any issue

@sjrl sjrl requested review from a team as code owners January 27, 2025 13:37
@sjrl sjrl requested review from dfokina and julian-risch and removed request for a team January 27, 2025 13:37
@coveralls
Copy link
Collaborator

coveralls commented Jan 27, 2025

Pull Request Test Coverage Report for Build 13006966682

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 6 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.02%) to 91.35%

Files with Coverage Reduction New Missed Lines %
components/converters/json.py 6 87.36%
Totals Coverage Status
Change from base Build 13006948321: 0.02%
Covered Lines: 8860
Relevant Lines: 9699

💛 - Coveralls

Copy link
Member

@julian-risch julian-risch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍
I quickly checked the other occurrences of the warning message "Skipping it". This one here in JSONConverter is the only one that didn't properly skip.

@sjrl sjrl merged commit bba84e5 into main Jan 28, 2025
18 checks passed
@sjrl sjrl deleted the json-converter-update branch January 28, 2025 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants