-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable writes to Azure #114
Conversation
@thovoll - oh snap. Test helper compile is failing because |
Thanks @xianwill, fixing this ASAP. |
3c5dc99
to
6dd8768
Compare
@mosyp would you be able to take a look at the failing integration tests? At least the coercion and dlq tests are confirmed failing. OTOH, we have the kdi process running fine in the Debian docker image. Possibly something going on with the integration test setup? |
aea6e2e
to
6fcf64f
Compare
6fcf64f
to
a4d308c
Compare
The reason the tests are failing is because of the upgrades to parquet, arrow and delta-rs. The ArrowWriter implementation has changed. In the old version, it would flush all of the records when calling the write method. In the version in this PR, the writer buffers the rows in memory until it reaches |
Closing this in favor of #136 which @mightyshazam and I are collaborating on. |
@xianwill and I paired on parts of this, thanks for your help Christian!
This PR upgrades kafka-delta-ingest to a newer version of delta-rs that includes Azure support.
Various libraries were upgraded as needed.
Dockerfile added and README updated to allow execution on Windows.
Deprecated temporarily allowed to avoid having to rewrite the clap code in the main module.