Skip to content

fix: fix get_content() call for frappe v16 compatibility #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
prateekkaramchandani wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fix: fix get_content() call for frappe v16 compatibility #44

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...xternal_storage/dfp_external_storage/doctype/dfp_external_storage/dfp_external_storage.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -574,10 +574,10 @@ def dfp_file_url_is_s3_location_check_if_s3_data_is_not_defined(self):
except:
pass

def get_content(self) -> bytes:
def get_content(self, encodings=None) -> bytes:
self.dfp_file_url_is_s3_location_check_if_s3_data_is_not_defined()
if not self.dfp_is_s3_remote_file():
return super(DFPExternalStorageFile, self).get_content()
return super(DFPExternalStorageFile, self).get_content(encodings=None)
try:
if not self.is_downloadable():
raise Exception("File not available")
Expand Down