fix: fix get_content() call for frappe v16 compatibility#44
Open
prateekkaramchandani wants to merge 1 commit into
Open
fix: fix get_content() call for frappe v16 compatibility#44prateekkaramchandani wants to merge 1 commit into
prateekkaramchandani wants to merge 1 commit into
Conversation
|
frappe does not check for read permission when-ever you do |
|
can we remove it in same pr? |
Profit-Rocket
added a commit
to Floreer-Africa/dfp_external_storage
that referenced
this pull request
May 13, 2026
Frappe v16 changed File.get_content() signature to accept an optional encodings parameter (frappe/frappe/core/doctype/file/file.py:592). Our DFPExternalStorageFile.get_content() subclass override didn't, so any caller passing encodings=... raised TypeError on v16. Forwards the parameter through to the parent for local-file lookups. S3-backed downloads still return raw bytes (the encoding param doesn't apply to remote object retrieval). Mirrors upstream PR developmentforpeople#44, with the typo corrected (upstream passes encodings=None which loses the caller's request; we pass encodings=encodings so the parameter actually propagates). When upstream merges developmentforpeople#44 (or a successor), reconcile via merge — this commit becomes a no-op or near-no-op.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.