chore: new fields for uninstalling code while taking canister snapshot #7855
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-weigelt
approved these changes
Dec 2, 2025
Contributor
michael-weigelt
left a comment
michael-weigelt
left a comment
There was a problem hiding this comment.
This is a non-breaking interface change. Is there a spec PR too?
Contributor
Author
Yes, I just created one: dfinity/portal#6168 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two extra fields to the input type of the
take_canister_snapshotmethod of the management canister:uninstall_code: allows to atomically uninstall the canister after taking its snapshot; in particular, the canister memory usage is updated atomically and thus it does not grow significantly (ignoring some potential constant overhead for certified variables which are not accounted for by canister memory usage, but are accounted for in canister snapshot memory usage),sender_canister_version: needed to record the sender canister version in the code uninstallation entry in canister history.Warning! The actual functionality will only be implemented in follow-up PRs.