chore: ICP Ninja Migration #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggreif
reviewed
Mar 12, 2025
ggreif
reviewed
Mar 12, 2025
ggreif
reviewed
Mar 12, 2025
service/saved/Saved.mo
Outdated
| @@ -37,7 +37,7 @@ actor { | |||
| let c : Nat32 = Prim.charToNat32(char); | |||
| x := ((x << 5) +% x) +% c; | |||
| }; | |||
| x | |||
| x; | |||
There was a problem hiding this comment.
I think (following Rust?) we don't add semis when the value gets returned. @rvanasa?
There was a problem hiding this comment.
This depends on how the formatter is configured (trailing semicolons by default in the Prettier ecosystem).
There was a problem hiding this comment.
Then just disable that on this project?
There was a problem hiding this comment.
The formatter puts this back in when I remove it
There was a problem hiding this comment.
@fxgst git pull and try reformatting
ggreif
reviewed
Mar 12, 2025
ggreif
reviewed
Mar 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.