chore(test): unskip previously skipped tests #9537
Open
+11
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/testing
This comment has been minimized.
This comment has been minimized.
matthewmcneely
changed the title
xqqp
reviewed
Dec 4, 2025
shiva-istari
force-pushed
the
shiva/test-unskip
branch
from
62cee3e to
74a508c
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
shiva-istari
force-pushed
the
shiva/test-unskip
branch
from
74a508c to
3067922
Compare
This comment has been minimized.
This comment has been minimized.
matthewmcneely
requested changes
Dec 8, 2025
shiva-istari
force-pushed
the
shiva/test-unskip
branch
from
5a2c367 to
33a196d
Compare
Contributor
|
@shiva-istari You missed two added skips in systest/backup/nfs-backup/backup_test.go, lines 41 and 47 |
Contributor
Author
@matthewmcneely What is the context behind skipping them? Are they flaky? I haven’t seen them failing recently. |
Contributor
@shiva-istari They would fail often when we were on the shared runners between the move. |
shiva-istari
force-pushed
the
shiva/test-unskip
branch
from
33a196d to
6337680
Compare
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.