-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: embedded superset dashboards #3205
Open
HendrikThePendric
wants to merge
47
commits into
master
Choose a base branch
from
feat/embedded-superset-dashboards-DHIS2-17891
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: embedded superset dashboards #3205
HendrikThePendric
wants to merge
47
commits into
master
from
feat/embedded-superset-dashboards-DHIS2-17891
+2,663
−572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🚀 Deployed on https://pr-3205.dashboard.netlify.dhis2.org |
47e9b85
to
a1c84ee
Compare
9cbe2e3
to
86a2794
Compare
0f2b16b
to
92bbefe
Compare
src/components/DashboardsBar/NavigationMenu/NavigationMenuDropdownButton.js
Show resolved
Hide resolved
src/components/ConfigureSupersetEmbeddedDashboardModal/CreateSupersetEmbeddedDashboard.js
Outdated
Show resolved
Hide resolved
Never use Superset and Embedded together, so that names are shorter and all superset dashboards are embedded so the embedded part is redundant anyway Move and rename the superset dashboard create/edit components
0e93af7
to
4946b6a
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO list based on KFMT session
(remove this section once completed)
superset-gateway/api/guestTokens
endpoint should start returning HTTP errors and error codes first.Implements DHIS2-17891
References
Key features
Partial PRs
Several PRs have been merged into this main feature PR. Please review PR descriptions and commit messages for a more granular view on the changes:
Note for testers
Since this feature is only available for instances which have Superset included, you will need to use such an instance when testing, i.e. https://debug.dhis2.org/dev. To test the dashboard-app, you can either use the Netlify link or run the app locally.
Screenshots
Choosing a dashboard type

Configuring a Superset embedded dashboard

Viewing a Superset embedded dashboard
