fix(mobile-config): run doctype_meta rename pre-sync + guard hook against missing column#35
Merged
Merged
Conversation
…inst missing column update_doctype_meta_modified reads doctype_meta_modified_at during schema sync, but rename_doctype_meta_modified_field ran in post_model_sync (after sync), so a site that still has the old typo'd column crashed migrate with 'Unknown column doctype_meta_modified_at'. Move the rename to pre_model_sync so the column is correct before any DocType on_update fires, and guard the hook with has_column so it can never abort a migrate regardless of sync ordering.
Omprakash-48
force-pushed
the
om/mobile-sync-bulk-fetch
branch
from
515acc9 to
cb8a32c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(mobile-config): run doctype_meta rename pre-sync + guard hook against missing column
update_doctype_meta_modified reads doctype_meta_modified_at during schema sync, but rename_doctype_meta_modified_field ran in post_model_sync (after sync), so a site that still has the old typo'd column crashed migrate with 'Unknown column doctype_meta_modified_at'. Move the rename to pre_model_sync so the column is correct before any DocType on_update fires, and guard the hook with has_column so it can never abort a migrate regardless of sync ordering.