Skip to content

fix(mobile-config): run doctype_meta rename pre-sync + guard hook against missing column #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bhushan-barbuddhe merged 1 commit into from
Jun 17, 2026
Merged

fix(mobile-config): run doctype_meta rename pre-sync + guard hook against missing column #35

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions mobile_control/mobile_control/doctype/mobile_configuration/mobile_configuration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,9 @@ def _ensure_mobile_uuid_field(doctype: str) -> None:


def update_doctype_meta_modified(doc: Document, method: str | None = None) -> None:
if not frappe.db.has_column("Mobile Configuration Form", "doctype_meta_modified_at"):
return

doctype_name = _get_doctype_name_from_doc(doc)
if not doctype_name:
return
Expand Down
2 changes: 1 addition & 1 deletion mobile_control/patches.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
[pre_model_sync]
# Patches added in this section will be executed before doctypes are migrated
# Read docs to understand patches: https://frappeframework.com/docs/v14/user/en/database-migrations
mobile_control.patches.v1_0.rename_doctype_meta_modified_field

[post_model_sync]
# Patches added in this section will be executed after doctypes are migrated
mobile_control.patches.v1_0.set_offline_enabled_default
mobile_control.patches.v1_0.rename_doctype_meta_modified_field
Loading