BMC: implement weak/strong sequences #1070
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kroening
force-pushed
the
sva-weak-strong
branch
13 times, most recently
from
c92ff47 to
4046fea
Compare
kroening
force-pushed
the
sva-weak-strong
branch
2 times, most recently
from
37334f8 to
86b4c58
Compare
|
Wants a rebase; but can you now also flip back to |
kroening
force-pushed
the
sva-weak-strong
branch
4 times, most recently
from
fb3b24a to
fd25950
Compare
tautschnig
approved these changes
Apr 25, 2025
src/trans-word-level/property.cpp
Outdated
Comment on lines
681
to
688
| // clang-format off | ||
| auto semantics = | ||
| property_expr.id() == ID_sva_strong ? sva_sequence_semanticst::STRONG | ||
| : property_expr.id() == ID_sva_weak ? sva_sequence_semanticst::WEAK | ||
| : property_expr.id() == ID_sva_implicit_strong ? sva_sequence_semanticst::STRONG | ||
| : property_expr.id() == ID_sva_implicit_weak ? sva_sequence_semanticst::WEAK | ||
| : sva_sequence_semanticst::WEAK; | ||
| // clang-format on |
There was a problem hiding this comment.
That's the same code (except different expression variable) twice in the same file - should probably be moved to a (static) function.
Cases relating to sequence expressions are now fully handled in property_obligations_rec.
This implements strong semantics for SVA sequences in the word-level BMC engine. Strong semantics are used with an explicit strong(...) operator or for SVA cover. The difference between weak and strong semantics arises in BMC when the sequence reaches the end of the unwinding: using weak semantics, the sequence matches, whereas using strong semantics the sequence does not.
kroening
force-pushed
the
sva-weak-strong
branch
from
fd25950 to
4cb485d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements strong semantics for SVA sequences in the word-level BMC engine. Strong semantics are used with an explicit
strong(...)operator or for SVAcover.The difference between weak and strong semantics arises in BMC when the sequence reaches the end of the unwinding: using weak semantics, the sequence matches, whereas using strong semantics the sequence does not.