security: Replace insecure Math.random() with cryptographic alternatives#325
Open
jose-compu wants to merge 1 commit into
Open
Conversation
- Use crypto.randomBytes for invoice number generation in invoice-service.ts - Use crypto.randomInt for AI email handle fallback generation in workspace-mapping.ts Math.random() is not cryptographically secure and can produce predictable values. For security-sensitive operations like generating invoice IDs and email handles, cryptographic randomness is required to prevent enumeration attacks. Fixes potential invoice ID prediction vulnerability. Related: Review of security best practices
|
@jose-blockchain is attempting to deploy a commit to the 0 Finance Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces insecure
Math.random()usage with cryptographically secure alternatives from Node.jscryptomodule.Problem
Math.random()is not cryptographically secure and can produce predictable values. In security-sensitive contexts like generating invoice IDs and email handles, this could enable:Changes
packages/web/src/lib/ai-email/invoice-service.tsMath.random()withcrypto.randomBytes()for invoice number generationpackages/web/src/lib/ai-email/workspace-mapping.tsMath.random()withcrypto.randomInt()for AI email handle fallbackTesting
randomBytes(3).toString('hex')produces 6-char hex string (same length as before)randomInt(n)produces same range asMath.floor(Math.random() * n)Security Impact
Potential Reviewers: @benjaminshafii
Related: Security audit / code review initiative