Skip to content

security: Replace insecure Math.random() with cryptographic alternatives #325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jose-compu wants to merge 1 commit into
base: main
Choose a base branch
from
Open

security: Replace insecure Math.random() with cryptographic alternatives #325

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions packages/web/src/lib/ai-email/invoice-service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import {
import { eq, and } from 'drizzle-orm';
import { parseUnits } from 'viem';
import Decimal from 'decimal.js';
import { randomBytes } from 'crypto';

/**
* Invoice Service for AI Email Agent
Expand Down Expand Up @@ -98,11 +99,13 @@ function getCurrencyDecimals(currency: string): number {
}

/**
* Generate a unique invoice number.
* Generate a unique invoice number using cryptographically secure random bytes.
* Uses crypto.randomBytes instead of Math.random() to prevent predictable invoice IDs.
*/
function generateInvoiceNumber(): string {
const timestamp = Date.now().toString(36).toUpperCase();
const random = Math.random().toString(36).substring(2, 6).toUpperCase();
// Use cryptographically secure random bytes instead of Math.random()
const random = randomBytes(3).toString('hex').toUpperCase();
return `AI-${timestamp}-${random}`;
}

Expand Down
9 changes: 5 additions & 4 deletions packages/web/src/lib/ai-email/workspace-mapping.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import { workspaces, workspaceMembers, users } from '@/db/schema';
import { eq, and, ilike } from 'drizzle-orm';
import { generateText } from 'ai';
import { createOpenAI } from '@ai-sdk/openai';
import { randomInt } from 'crypto';

/**
* Workspace Mapping for AI Email Agent
Expand Down Expand Up @@ -413,7 +414,7 @@ Generate a unique handle:`,
}
}

// Fallback: Generate a random handle
// Fallback: Generate a random handle using cryptographically secure randomness
const fallbackNames = [
'alex.morgan',
'jordan.lee',
Expand All @@ -424,9 +425,9 @@ Generate a unique handle:`,
'avery.wilson',
'blake.thomas',
];
const randomName =
fallbackNames[Math.floor(Math.random() * fallbackNames.length)];
const randomSuffix = Math.floor(Math.random() * 1000);
// Use crypto.randomInt instead of Math.random() for secure randomness
const randomName = fallbackNames[randomInt(fallbackNames.length)];
const randomSuffix = randomInt(1000);
const fallbackHandle = `ai-${randomName}${randomSuffix}`;

if (!existingSet.has(fallbackHandle)) {
Expand Down