test(fleet,infra): use neutral fixture username in operations tests - #333
Merged
jmagar merged 1 commit intoAug 5, 2026
Conversation
Replace the real username 'jmagar' with the neutral placeholder 'devuser' in fleet and infra test fixtures, including the /home/jmagar/.ssh/* paths in the OpenSSH connector and endpoint tests and the user column of the ps-output fixtures. Follows the precedent set by #326 (devhost fixture hostname) and completes the hostname scrub in #325, which neutralized host names but left the username in place. Test fixture literals only; no behavior change.
jmagar
merged commit Aug 5, 2026
9408cc2
into
chore/scrub-internal-identifiers-20260805
2 checks passed
jmagar
added a commit
that referenced
this pull request
Aug 6, 2026
* chore: scrub internal network identifiers Replace internal IP addresses, the internal tailnet domain, and host aliases in tracked files with neutral documentation placeholders (192.0.2.0/24, 198.51.100.0/24, example.ts.net, *.example.internal, role-based host aliases). * fix: address review findings on identifier scrub - Run cargo fmt on topology_tests.rs (line exceeded wrap width after the devhost rename) - Rename old_dookie/new_dookie -> old_devhost/new_devhost in cache_tests.rs so local variable names don't retain the raw internal hostname substring - Rename squirts_pos -> edgehost_pos in formatters_tests.rs for the same reason - Re-pad the doc-comment example markdown table in formatters/host.rs after the squirts->edgehost substitution widened a column * test(fleet,infra): use neutral fixture username in operations tests (#333) Replace the real username 'jmagar' with the neutral placeholder 'devuser' in fleet and infra test fixtures, including the /home/jmagar/.ssh/* paths in the OpenSSH connector and endpoint tests and the user column of the ps-output fixtures. Follows the precedent set by #326 (devhost fixture hostname) and completes the hostname scrub in #325, which neutralized host names but left the username in place. Test fixture literals only; no behavior change.
jmagar
added a commit
that referenced
this pull request
Aug 22, 2026
Completes the identifier scrub started in #325/#333 by replacing the last real-username fixture literals with the neutral 'devuser' placeholder: - soma-auth sqlite session fixture email - synapse-application process-row observability fixture - synapse import syslog/auth log samples (already on 'devhost') Excludes xtask scaffolding defaults (github_owner) and historical CHANGELOG commit URLs, which are real values rather than fixtures. Test fixture literals only; no behavior change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Replaces the real username
jmagarwith the neutral placeholderdevuserin thesoma-fleetandsoma-infratest fixtures — 26 literals across 8 files.This covers three shapes of the identifier:
ssh("devhost", "jmagar")→ssh("devhost", "devuser")/home/jmagar/.ssh/{id_ed25519,config,known_hosts}→/home/devuser/...ps-output fixtures inprocess_tests.rs/process_process_tests.rsWhy
Follows the precedent set by #326, which introduced the neutral
devhostfixture hostname for the synapse mutation-exec tests.#325 already neutralized the host names across these same files (
dookie→devhost,squirts→edgehost) but deliberately left the username in place. This PR is stacked on that branch and finishes the job, so nojmagarliteral remains anywhere undercrates/shared/operations/.Scope
Test fixture literals only — no behavior change. The diff is exactly symmetric (26 insertions, 26 deletions); every changed line is a string literal inside a test.
The
psfixtures parse on whitespace, so the shorter username does not affect column parsing, and thewith_user(...)filter that selects those rows is renamed in the same commit.Verification
Note on base branch
Based on
chore/scrub-internal-identifiers-20260805(#325) rather thanmain, so the diff shows only the username change. Merge after #325; retarget tomainif #325 is closed instead.