test: add exec unit tests and varlock run smoke tests#707
Merged
Conversation
Copilot
AI
changed the title
[WIP] Fix child stdout/stderr loss in varlock on Windows PowerShell
fix(exec): use May 20, 2026
close event instead of exit to prevent piped stdout/stderr loss on Windows
Member
|
@copilot fix the build issue with |
Contributor
Author
Fixed in 3c1e2b2. Added |
Contributor
commit: |
Member
|
@theoephraim looks like the associated issue was already resolved in |
…stdout/stderr loss on Windows Agent-Logs-Url: https://github.com/dmno-dev/varlock/sessions/88778d17-339f-4845-8a95-e568d205c190 Co-authored-by: philmillman <3722211+philmillman@users.noreply.github.com>
…ming threshold Agent-Logs-Url: https://github.com/dmno-dev/varlock/sessions/88778d17-339f-4845-8a95-e568d205c190 Co-authored-by: philmillman <3722211+philmillman@users.noreply.github.com>
Agent-Logs-Url: https://github.com/dmno-dev/varlock/sessions/88778d17-339f-4845-8a95-e568d205c190 Co-authored-by: philmillman <3722211+philmillman@users.noreply.github.com>
The underlying stdout loss issue was resolved in 1.2.0. Drop the exec.ts code change, changeset, devalue override, and erroneous smoke-tests/bun.lock. Retain the new unit tests for exec (piping, exit codes, timing) and smoke tests for `varlock run`.
theoephraim
force-pushed
the
copilot/bugfix-child-stdout-loss
branch
from
3c1e2b2 to
d9f9c48
Compare
theoephraim
changed the title
close event instead of exit to prevent piped stdout/stderr loss on Windows
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
exec(): stdout/stderr piping, exit code propagation, inherited stdio, timing assertionvarlock run: stdout forwarding, exit code propagation, stderr forwardingexit→closecode change (underlying issue was resolved in 1.2.0)smoke-tests/bun.lockTest plan
bun run --filter varlock test -- --run src/lib/test/exec.test.ts— 5 tests passbun run lint:fix— clean