test: add exec unit tests and varlock run smoke tests

.bumpy/exec-test-coverage.md

@@ -0,0 +1,2 @@
+---
+---

packages/varlock/src/lib/test/exec.test.ts

@@ -0,0 +1,86 @@
+import { describe, it, expect } from 'vitest';
+import { Readable } from 'node:stream';
+import { exec } from '../exec.js';
+
+/**
+ * Collect all data from a Readable stream into a string.
+ */
+async function streamToString(stream: Readable): Promise<string> {
+  const chunks: Array<Buffer | string> = [];
+  for await (const chunk of stream) {
+    chunks.push(chunk);
+  }
+  return chunks.join('');
+}
+
+describe('exec', () => {
+  it('should forward child stdout with piped stdio', async () => {
+    // This test validates that stdout data is fully available when the
+    // Promise resolves. The bug (exit vs close) would cause this to race:
+    // on a slow machine or Windows the data events might not have fired
+    // by the time process.exit() is called after `await commandProcess`.
+    const childProcess = exec('node', ['-p', '1+1'], {
+      stdout: 'pipe',
+      stderr: 'pipe',
+    });
+
+    const stdoutData = childProcess.stdout ? streamToString(childProcess.stdout) : Promise.resolve('');
+
+    const result = await childProcess;
+    expect(result.exitCode).toBe(0);
+
+    // All pipe data must be available once the Promise resolves (close event)
+    const output = await stdoutData;
+    expect(output.trim()).toBe('2');
+  });
+
+  it('should propagate non-zero exit code', async () => {
+    let exitCode: number;
+    try {
+      await exec('node', ['-e', 'process.exit(42)'], {
+        stdout: 'pipe',
+        stderr: 'pipe',
+      });
+      exitCode = 0;
+    } catch (error: any) {
+      exitCode = error.exitCode;
+    }
+    expect(exitCode).toBe(42);
+  });
+
+  it('should forward child stderr with piped stdio', async () => {
+    const childProcess = exec('node', ['-e', 'process.stderr.write("err-output\\n")'], {
+      stdout: 'pipe',
+      stderr: 'pipe',
+    });
+
+    const stderrData = childProcess.stderr ? streamToString(childProcess.stderr) : Promise.resolve('');
+
+    const result = await childProcess;
+    expect(result.exitCode).toBe(0);
+
+    const output = await stderrData;
+    expect(output.trim()).toBe('err-output');
+  });
+
+  it('should resolve with inherited stdio', async () => {
+    const result = await exec('node', ['-e', 'process.exit(0)'], {
+      stdio: 'inherit',
+    });
+    expect(result.exitCode).toBe(0);
+  });
+
+  it('should resolve after child fully runs (not prematurely)', async () => {
+    const startMs = Date.now();
+    const result = await exec('node', ['-e', 'setTimeout(() => {}, 300)'], {
+      stdout: 'pipe',
+      stderr: 'pipe',
+    });
+    const elapsedMs = Date.now() - startMs;
+    expect(result.exitCode).toBe(0);
+    // The child runs a 300ms setTimeout, so the Promise must not resolve before
+    // the child exits. We assert ≥200ms (100ms slack for slow/loaded CI runners)
+    // to avoid flakiness while still catching a premature resolve (e.g. <50ms).
+    expect(elapsedMs).toBeGreaterThanOrEqual(200);
+  });
+});

smoke-tests/tests/cli.test.ts

@@ -127,6 +127,30 @@ describe('CLI Commands', () => {
     });
   });
 
+  describe('run command', () => {
+    test('varlock run should forward child stdout', () => {
+      const result = varlockRun(['node', '-p', '1+1'], { cwd: 'smoke-test-basic' });
+      expect(result.exitCode).toBe(0);
+      expect(result.output.trim()).toBe('2');
+    });
+
+    test('varlock run should propagate non-zero exit code', () => {
+      const result = varlockRun(['node', '-e', 'process.exit(42)'], {
+        cwd: 'smoke-test-basic',
+      });
+      expect(result.exitCode).toBe(42);
+    });
+
+    test('varlock run should forward child stderr', () => {
+      const result = varlockRun(
+        ['node', '-e', 'process.stderr.write("error-output\\n")'],
+        { cwd: 'smoke-test-basic' },
+      );
+      expect(result.exitCode).toBe(0);
+      expect(result.output).toContain('error-output');
+    });
+  });
+
   describe('type generation', () => {
     const typeFilePath = join(SMOKE_TESTS_DIR, 'smoke-test-basic', 'env.d.ts');
     const typeFilePathAutoFalse = join(SMOKE_TESTS_DIR, 'smoke-test-typegen-auto', 'env.d.ts');