chore: require manual Roslyn minor and major upgrades - #11150
Merged
Merged
Conversation
Keep patch updates eligible while preserving the intentional target-framework compatibility split. Repair the invalid overlapping NuGet update block using the approach proposed in dotnet#10951, retaining manual Verify updates. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: c2f0e734-2e18-49fa-a38e-a91a33e1aa1f
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Keep routine Roslyn patch updates eligible for Dependabot, but require manual review for minor and major upgrades.
version-update:semver-minorandversion-update:semver-majorforMicrosoft.CodeAnalysisandMicrosoft.CodeAnalysis.*.Verify.*updates manual.Why
#11124 intentionally uses Roslyn 5.6 for net8.0/net9.0 and 5.9 for the newer target. #11148 repeats the incompatible 5.6 -> 5.9 update for the older targets, as did the closed #11118 and #11129.
Dependabot ignore rules are package-level, not target-framework-level. This is a deliberate tradeoff: routine Roslyn minor/major upgrades for net10.0 also become manual. Patch updates remain allowed by policy; this does not claim independent scheduling for each conditional PackageVersion entry.
These update-type ignores apply to version updates, not security-only updates. They do not disable vulnerability alerts or suppress security update review.
Validation
Dependabot::Config::IgnoreConditionand its upstream tests.These are local schema and policy-intent checks, not a hosted Dependabot update run. The new policy takes effect only after merge.
Related: #11148, #11124, #10951.