Skip to content

Improve msbuild logger for testing workloads - #9706

Merged
rokonec merged 21 commits into
mainfrom
exp/terminal-logger-for-vstest
Feb 19, 2024
Merged

Improve msbuild logger for testing workloads#9706
rokonec merged 21 commits into
mainfrom
exp/terminal-logger-for-vstest

Conversation

@nohwnd

@nohwnd nohwnd commented Feb 2, 2024

Copy link
Copy Markdown
Member

Part of microsoft/vstest#4843
Needs microsoft/vstest#4877 to work, but does not break without it.

Context

Terminal logger is reporting build, but when tests run via MSBuild there is very little feedback about what is going on.

logger

image

image

image

image

Changes Made

Adds colored test results where targets are normally.
Writes summary for tests after the test run.
Writes result for every test projects, no matter if it fails or succeeds.

Testing

yup.

Notes

In comments.

@baronfel

baronfel commented Feb 2, 2024

Copy link
Copy Markdown
Member

@rainersigwald aren't we working on removing the project prefix for each error report or something?

Comment thread src/MSBuild.UnitTests/NodeStatus_Transition_Tests.cs
Comment thread src/MSBuild/TerminalLogger/NodesFrame.cs
Comment thread src/MSBuild/TerminalLogger/TerminalLogger.cs Outdated
Comment thread src/MSBuild/TerminalLogger/TerminalLogger.cs
Comment thread src/Framework/Logging/AnsiCodes.cs Outdated
Comment thread src/MSBuild/TerminalLogger/TerminalLogger.cs
@nohwnd
nohwnd marked this pull request as ready for review February 8, 2024 15:41
@nohwnd

nohwnd commented Feb 8, 2024

Copy link
Copy Markdown
Member Author

@baronfel @rainersigwald @rokonec I am close to happy. Would love to know if I need to change something significantly.

Comment thread src/MSBuild.UnitTests/NodeStatus_Transition_Tests.cs
Comment thread src/MSBuild/TerminalLogger/TerminalLogger.cs
Comment thread src/Framework/Logging/AnsiCodes.cs Outdated
Comment thread src/MSBuild/TerminalLogger/NodesFrame.cs Outdated
Comment thread src/MSBuild/TerminalLogger/TerminalLogger.cs
Comment thread src/Framework/Logging/AnsiCodes.cs Outdated
Comment thread src/MSBuild/TerminalLogger/NodeStatus.cs
Comment thread src/MSBuild.UnitTests/NodeStatus_Transition_Tests.cs
Comment thread src/Framework/Logging/AnsiCodes.cs
Comment thread src/MSBuild.UnitTests/NodeStatus_SizeChange_Tests.cs Outdated
Comment thread src/MSBuild.UnitTests/NodeStatus_Transition_Tests.cs
Comment thread src/MSBuild/TerminalLogger/NodeStatus.cs
Comment thread src/MSBuild/TerminalLogger/NodeStatus.cs
Comment thread src/MSBuild/TerminalLogger/TerminalLogger.cs Outdated
Comment thread src/MSBuild/TerminalLogger/TerminalLogger.cs
Comment thread src/MSBuild/TerminalLogger/TerminalLogger.cs
Comment thread src/MSBuild/TerminalLogger/TestSummary.cs Outdated
@rokonec
rokonec merged commit 93c2acc into main Feb 19, 2024
@rokonec
rokonec deleted the exp/terminal-logger-for-vstest branch February 19, 2024 13:57
@nohwnd

nohwnd commented Feb 21, 2024

Copy link
Copy Markdown
Member Author

Available in dotnet/installer since 9.0.100-preview.2.24121.2 if anyone wants to try.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants