Improve terminal logger - #4877
Merged
Jakub Jareš (nohwnd) merged 26 commits intoFeb 13, 2024
Merged
Conversation
Co-authored-by: Amaury Levé <amaury.leve@gmail.com>
…wnd/vstest into fix-terminal-logger-encoding
Jakub Jareš (nohwnd)
force-pushed
the
terminal-logger-for-vstest
branch
from
February 7, 2024 16:51
60174dd to
3d7c420
Compare
Jakub Jareš (nohwnd)
marked this pull request as ready for review
February 9, 2024 12:37
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
Michael Simons (@MichaelSimons) we are adding some pre-builts exclusions here. Is there anything more that needs to be done? |
Amaury Levé (Evangelink)
left a comment
Member
There was a problem hiding this comment.
I only did a shallow review but LGTM. Let me know if I should pull the code and make some tests to provide a full review.
This was referenced Aug 22, 2026
Open
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #4843