Optimize icon rendering: simplify logic and eliminate redundant calculations #13449
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lations - Replaced HDC with Graphics in DrawIcon() for smoother GDI+ integration - Optimized Rectangle management – removed unnecessary variables, directly adjusting sizes - Simplified stretch logic (Inflate) – replaced complex calculations with a concise method call - Unified Draw() and DrawUnstretched() – now both directly call DrawIcon() without intermediate processing - Eliminated duplicate Matrix.Offset calculations, ensuring targetRect is adjusted directly - No functional changes, just cleaner, more maintainable code 🚀
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #13449 +/- ##
====================================================
+ Coverage 62.21083% 76.60189% +14.39105%
====================================================
Files 3213 3230 +17
Lines 638302 639043 +741
Branches 47201 47287 +86
====================================================
+ Hits 397093 489519 +92426
+ Misses 234153 145951 -88202
+ Partials 7056 3573 -3483
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regression?
Microsoft Reviewers: Open in CodeFlow