Skip to content

Simplify push_box's camera height logic #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jacobtkeio wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Simplify push_box's camera height logic #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions Obscura/scripts/camera_controllers/camera_controller_base.gd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ extends Camera3D

func _ready() -> void:
current = false
position += Vector3(0.0, dist_above_target, 0.0)
position = target.position + Vector3(0.0, dist_above_target, 0.0)


func _process(delta: float) -> void:
Expand All @@ -38,9 +38,6 @@ func _process(delta: float) -> void:
#if abs(_camera_tilt_rad) < 0.01:
#_camera_tilt_rad = 0.0
#rotation.z = _camera_tilt_rad

position.y = target.position.y + dist_above_target



@abstract func _draw_logic() -> void
5 changes: 0 additions & 5 deletions Obscura/scripts/camera_controllers/push_box.gd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,6 @@ extends CameraControllerBase
@export var box_height:float = 10.0


func _ready() -> void:
super()
position = target.position


func _process(delta: float) -> void:
if !current:
return
Expand Down