feat(server) : add logs to investigate test_take_over_seeder #5392
+15
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kostasrim
previously approved these changes
Jul 1, 2025
mkaruza
force-pushed
the
test_take_over_seeder
branch
from
18e3b29 to
87b6516
Compare
|
Pushed commit to test only regression-test with (ubuntu-dev:20, Uring, Debug, ubuntu-latest) matrix where test fails |
mkaruza
force-pushed
the
test_take_over_seeder
branch
from
87b6516 to
3c59f4a
Compare
|
@adiholden please rebase |
Signed-off-by: adi_holden <[email protected]>
mkaruza
force-pushed
the
test_take_over_seeder
branch
from
2db4c34 to
8d0f743
Compare
adiholden
commented
Jul 10, 2025
| proactor_threads=master_threads, | ||
| dbfilename=f"dump_{tmp_file_name()}", | ||
| admin_port=ADMIN_PORT, | ||
| vmodule="rdb_save=1,dflycmd=1,snapshot=1,streamer=3", |
There was a problem hiding this comment.
I believe you can remove the vmodule change from this test.
Keeping the vlog changes introduced in this PR for future investigations if needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increase log verbosity to debug the failing test.