Upgrades web3.py version in requirements#202
Open
konichuvak wants to merge 1 commit intodydxprotocol:masterfrom
Open
Upgrades web3.py version in requirements#202konichuvak wants to merge 1 commit intodydxprotocol:masterfrom
konichuvak wants to merge 1 commit intodydxprotocol:masterfrom
Conversation
This was referenced Jul 12, 2023
|
+1 |
|
when merge? |
|
+1!!! I need this to use websockets 11! |
|
I made a fork of this and released it on PyPI: |
CharlesFr
approved these changes
Oct 20, 2023
IngLP
approved these changes
Oct 26, 2023
|
any update on this one? Having to use the fork provided by saleh-mir to get around dependency conflicts. |
@saleh-mir Can you update Also, this package doesn't include the solidity_keccak changes 😩 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main motivation behind bumping the version is to allow
websockets>=10.The v5 versions of web3 fix the
websocketsversion to <10, which capped the version of thewebsocketslibrary that was possible to be used. However, in the latest release the cap was removed.This update allows for latest v5 (5.31.4) and v6, which would avoid dependency conflicts with
websocketslibrary.