chore(api): rector to php80 #8332
Merged
+97
−170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BacLuc
force-pushed
the
rector-new-fixes
branch
from
3efcfe8 to
54c81ea
Compare
I know we started with php 8 with this version of the backend, but it seems we did not write php8 code. Disable ClosureToArrowFunctionRector for now because too much would change, and one can argue that it's a choice to use a closure instead of an arrow function.
BacLuc
force-pushed
the
rector-new-fixes
branch
from
54c81ea to
6a23a92
Compare
carlobeltrame
approved these changes
Oct 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I know we started with php 8 with this version of the backend, but it seems we did not write php8 code.
Disable ClosureToArrowFunctionRector for now because too much would change, and one can argue that it's a choice to use a closure instead of an arrow function.