Skip to content

Conversation

laeubi
Copy link
Contributor

@laeubi laeubi commented Apr 24, 2025

WinPTY is no longer well supported and maybe even non functional anymore.

This is an attempt to remove it entirely, see comment here:

@jonahgraham jonahgraham added releng Release engineering and project management terminal The TM Terminal collection of features in CDT labels Oct 8, 2025
Copy link
Member

@jonahgraham jonahgraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also cleaned up the Makefile to remove some references to now removed pty.dll.

This PR site on top of #1146 for the moment.

@jonahgraham
Copy link
Member

Thanks @laeubi for doing this code cleanup. If/when we move this code to Platform having some of these items simplified will certainly help.

We also don't have the exact source used to build the winpty dll/exe that is in CDT. The source code may be in bugzilla, but the main place I know it to have been was in ipzilla. This has been fully archived and I don't even want to consider what it would take to get this source back out, let alone rebuild it. Therefore I am delighted to get this debt out of CDTs codebase.

Once #1146 is merged I will rebase and merge this too (assuming clean CI of course)

WinPTY is no longer well supported and maybe even non functional anymore.
Copy link

Test Results

  585 files  ±0    585 suites  ±0   13m 43s ⏱️ -33s
9 914 tests ±0  9 890 ✅ ±0  24 💤 ±0  0 ❌ ±0 
9 952 runs  ±0  9 928 ✅ ±0  24 💤 ±0  0 ❌ ±0 

Results for commit 2f5548d. ± Comparison against base commit 8b22be8.

@jonahgraham jonahgraham merged commit 2f5548d into eclipse-cdt:main Oct 14, 2025
5 checks passed
@jonahgraham jonahgraham added this to the 12.3.0 milestone Oct 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

releng Release engineering and project management terminal The TM Terminal collection of features in CDT

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants