Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions NewAndNoteworthy/CDT-12.3.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,12 @@ This is the New & Noteworthy page for CDT 12.3 which is part of Eclipse 2025-12

Core Build CMake and Makefile projects now support the Gdb Remote TCP and Serial launch targets.

## Support for WinPTY terminals has been removed

Since CDT 10.6 the default settings in CDT has [been to not use WinPTY](https://github.com/eclipse-cdt/cdt/blob/main/NewAndNoteworthy/CDT-10.6.md#windows-pseudo-console-conpty-the-default).
With this release of CDT the WinPTY version of the code has been removed.
The WinPTY code was known to not work in many circumstances.
The replacement Windows Pseudo Console (ConPTY) API is much more stable.

# API Changes, current and planned

Expand Down
13 changes: 1 addition & 12 deletions core/org.eclipse.cdt.core.native/native_src/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@ ifeq ($(UNAME),Linux)
LIBS = \
$(OS_DIR_WIN32_X86_64)/starter.exe \
$(OS_DIR_WIN32_X86_64)/spawner.dll \
$(OS_DIR_WIN32_X86_64)/pty.dll \
$(OS_DIR_LINUX_X86_64)/libspawner.so \
$(OS_DIR_LINUX_X86_64)/libpty.so \
$(OS_DIR_LINUX_AARCH64)/libspawner.so \
Expand Down Expand Up @@ -68,8 +67,7 @@ LIBS = \
else
LIBS = \
$(OS_DIR_WIN32_X86_64)/starter.exe \
$(OS_DIR_WIN32_X86_64)/spawner.dll \
$(OS_DIR_WIN32_X86_64)/pty.dll
$(OS_DIR_WIN32_X86_64)/spawner.dll
endif
endif
endif
Expand All @@ -87,7 +85,6 @@ MAC_TO_SIGN=$(OS_DIR_MACOS_X86_64)/libspawner.jnilib \
$(OS_DIR_MACOS_AARCH64)/libpty.jnilib
WIN_TO_SIGN=$(OS_DIR_WIN32_X86_64)/starter.exe \
$(OS_DIR_WIN32_X86_64)/spawner.dll \
$(OS_DIR_WIN32_X86_64)/pty.dll \
$(OS_DIR_WIN32_AARCH64)/starter.exe \
$(OS_DIR_WIN32_AARCH64)/spawner.dll
### This block of code also exists in native/org.eclipse.cdt.native.serial/native_src/Makefile
Expand Down Expand Up @@ -130,14 +127,6 @@ $(OS_DIR_WIN32_X86_64)/spawner.dll: win/iostream.c win/raise.c win/spawner.c win
$^ \
-Wl,--kill-at --shared

$(OS_DIR_WIN32_X86_64)/pty.dll: win/pty.cpp win/pty_dllmain.cpp win/util.c
mkdir -p $(dir $@) && \
$(REPRODUCIBLE_BUILD_WRAPPER) \
x86_64-w64-mingw32-g++ $(COMMON_CCFLAGS) -o $@ -Iinclude -Iwin/include -I"$(JAVA_HOME)/include" -I"$(JAVA_HOME)/include/win32" \
-DUNICODE \
$^ \
-Wl,--kill-at --shared -L$(OS_DIR_WIN32_X86_64) -lwinpty -static-libstdc++ -static-libgcc

# Windows aarch64
$(OS_DIR_WIN32_AARCH64)/starter.exe: win/starter.c win/util.c
mkdir -p $(dir $@) && \
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

105 changes: 0 additions & 105 deletions core/org.eclipse.cdt.core.native/native_src/win/include/winpty.h

This file was deleted.

Loading
Loading