Refactor: Move GTK-specific DPI logic to GtkDPIUtil #2280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShahzaibIbrahim
force-pushed
the
master-287-gtk
branch
from
31e4bc1 to
58bbc0c
Compare
akoch-yatta
reviewed
Jul 1, 2025
bundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/internal/GtkDPIUtil.java
Outdated
Show resolved
Hide resolved
bundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/internal/GtkDPIUtil.java
Outdated
Show resolved
Hide resolved
This commit introduces a dedicated `GtkDPIUtil` class to isolate GTK-specific DPI logic, improving platform separation and maintainability. Since the GTK scaling factor is always 1, the `autoScaleUp` and `autoScaleDown` methods effectively return the input unchanged. These methods and their usages have been removed from the GTK implementation to eliminate unnecessary code. Also clarifies that `autoScale` no longer applies to the Win32 implementation and is being decoupled accordingly.
ShahzaibIbrahim
force-pushed
the
master-287-gtk
branch
from
58bbc0c to
daf36ff
Compare
This was
linked to
issues
Jul 2, 2025
This was
unlinked from
issues
Jul 2, 2025
fedejeanne
approved these changes
Jul 2, 2025
There was a problem hiding this comment.
LGTM but since this is GTK, I would like the opinion of @iloveeclipse and/or @akurtakov before merging it.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces a dedicated
GtkDPIUtilclass to isolate GTK-specific DPI logic, improving platform separation and maintainability.Since the GTK scaling factor is always 1, the
autoScaleUpandautoScaleDownmethods effectively return the input unchanged. These methods and their usages have been removed from the GTK implementation to eliminate unnecessary code.Also clarifies that
autoScaleno longer applies to the Win32 implementation and is being decoupled accordingly.