-
Notifications
You must be signed in to change notification settings - Fork 13
Tidy up #98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tidy up #98
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #98 +/- ##
===========================================
- Coverage 63.90% 63.89% -0.01%
===========================================
Files 281 281
Lines 15809 15804 -5
Branches 1644 1642 -2
===========================================
- Hits 10102 10098 -4
+ Misses 5707 5706 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
9b6295d
to
c0825d9
Compare
There is no need to null check a pointer before deleting because 'delete ptr' where prt = nullptr is a NO-OP.
'git blame' can be configured to ignore specific commits such as reformatting the codebase with clang format. We track the commits we want to be ignored in .git-blame-ignore-revs. You can use git blame from the cli with: git blame --ignore-revs-file .git-blame-ignore-revs <FILE> Or you configure your git config to always use .git-blame-ignore-revs by setting: git config blame.ignoreRevsFile .git-blame-ignore-revs Or extending your gitconfig with: [blame] ignoreRevsFile = .git-blame-ignore-revs Note that .git-blame-ignore-revs is recognized by GitHub.
Move- constructor / assignment operator can be defaulted in this case. Silencing the use-after-move warning. In this specific case there was no bug in the existing code because we moved only the base class part.
- bugprone-assignment-in-if-condition - bugprone-bool-pointer-implicit-conversion - bugprone-unused-return-value,
Added bugprone-casting-through-void
@simondsmart I talked to @wdeconinck and @pmaciel about https://clang.llvm.org/extra/clang-tidy/checks/readability/delete-null-pointer.html and the resonance was positive. |
This PR enables a few more tidy checks and addresses them. Additionally it adds a way for git blame to ignore changed from our big reformatting.
Removed unneeded if
There is no need to null check a pointer before deleting because 'delete
ptr' where prt = nullptr is a NO-OP.
Add .git-blame-ignore-revs
'git blame' can be configured to ignore specific commits such as
reformatting the codebase with clang format.
We track the commits we want to be ignored in .git-blame-ignore-revs.
You can use git blame from the cli with:
git blame --ignore-revs-file .git-blame-ignore-revs
Or you configure your git config to always use .git-blame-ignore-revs by
setting:
git config blame.ignoreRevsFile .git-blame-ignore-revs
Or extending your gitconfig with:
[blame]
ignoreRevsFile = .git-blame-ignore-revs
Note that .git-blame-ignore-revs is recognized by GitHub.
Introduce tidy bugprone-use-after-move
Move- constructor / assignment operator can be defaulted in this case.
Silencing the use-after-move warning. In this specific case there was no
bug in the existing code because we moved only the base class part.
Add aditional tidy checks
Added new tidy-check and fixed warning
Added bugprone-casting-through-void