Tidy up

.clang-tidy

@@ -3,7 +3,13 @@ UseColor: On
 Checks: >-
   -*,
   readability-delete-null-pointer,
+  bugprone-assignment-in-if-condition,
+  bugprone-bool-pointer-implicit-conversion,
+  bugprone-casting-through-void,
   bugprone-parent-virtual-call,
+  bugprone-unused-return-value,
+  bugprone-use-after-move,
+
 
 WarningsAsErrors:             false
 HeaderFileExtensions:         ['', 'h','hh','hpp','hxx']

.git-blame-ignore-revs

@@ -0,0 +1,11 @@
+# The following refs can be ignored by git blame if 'git blame' is called with
+# --ignore-revs-file .git-blame-ignore-revs
+# Alternatively configure git to always ignore refs stored in this file by
+# calling:
+#   git config blame.ignoreRevsFile .git-blame-ignore-revs
+# Or extend your git config manually with
+# [blame]
+#    ignoreRevsFile = .git-blame-ignore-revs
+
+# Reformatted codebase with clang-format
+efb1ad8497bc43a84d7a90fe58b25a242aa13183

src/fdb5/api/helpers/ListIterator.h

@@ -54,17 +54,9 @@ class ListIterator : public APIIterator<ListElement> {
     ListIterator(APIIterator<ListElement>&& iter, bool deduplicate = false) :
         APIIterator<ListElement>(std::move(iter)), seenKeys_({}), deduplicate_(deduplicate) {}
 
-    ListIterator(ListIterator&& iter) :
-        APIIterator<ListElement>(std::move(iter)),
-        seenKeys_(std::move(iter.seenKeys_)),
-        deduplicate_(iter.deduplicate_) {}
-
-    ListIterator& operator=(ListIterator&& iter) {
-        seenKeys_    = std::move(iter.seenKeys_);
-        deduplicate_ = iter.deduplicate_;
-        APIIterator<ListElement>::operator=(std::move(iter));
-        return *this;
-    }
+    ListIterator(ListIterator&& iter) = default;
+
+    ListIterator& operator=(ListIterator&& iter) = default;
 
     bool next(ListElement& elem);
 

src/fdb5/database/EntryVisitMechanism.cc

@@ -45,9 +45,7 @@ bool EntryVisitor::preVisitDatabase(const eckit::URI& /*uri*/, const Schema& /*s
 EntryVisitor::EntryVisitor() : currentCatalogue_(nullptr), currentStore_(nullptr), currentIndex_(nullptr) {}
 
 EntryVisitor::~EntryVisitor() {
-    if (currentStore_) {
-        delete currentStore_;
-    }
+    delete currentStore_;
 }
 
 Store& EntryVisitor::store() const {

src/fdb5/io/FieldHandle.cc

@@ -111,9 +111,7 @@ FieldHandle::~FieldHandle() {
     if (current_ && currentMemoryHandle_) {
         delete current_;
     }
-    if (buffer_) {
-        delete[] buffer_;
-    }
+    delete[] buffer_;
 }
 
 void FieldHandle::openCurrent() {

src/fdb5/remote/server/ServerConnection.cc

@@ -354,10 +354,10 @@ size_t ServerConnection::archiveThreadLoop() {
             if (elem.multiblob_) {
                 // Handle MultiBlob
 
-                const char* firstData = static_cast<const char*>(elem.payload_.data());  // For pointer arithmetic
+                const char* firstData = reinterpret_cast<const char*>(elem.payload_.data());  // For pointer arithmetic
                 const char* charData  = firstData;
                 while (size_t(charData - firstData) < elem.payload_.size()) {
-                    const MessageHeader* hdr = static_cast<const MessageHeader*>(static_cast<const void*>(charData));
+                    const MessageHeader* hdr = reinterpret_cast<const MessageHeader*>(charData);
                     ASSERT(hdr->message == Message::Blob);
                     ASSERT(hdr->clientID() == elem.clientID_);
                     ASSERT(hdr->requestID == elem.requestID_);
@@ -366,7 +366,7 @@ size_t ServerConnection::archiveThreadLoop() {
                     const void* payloadData = charData;
                     charData += hdr->payloadSize;
 
-                    const auto* e = static_cast<const MessageHeader::MarkerType*>(static_cast<const void*>(charData));
+                    const auto* e = reinterpret_cast<const MessageHeader::MarkerType*>(charData);
                     ASSERT(*e == MessageHeader::EndMarker);
                     charData += MessageHeader::markerBytes;