Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: expose -keep_resize_below_overflow with PL_KEEP_RESIZE_BELOW_OVERFLOW #655

Merged
merged 11 commits into from
Feb 13, 2025
Merged

feat: expose -keep_resize_below_overflow with PL_KEEP_RESIZE_BELOW_OVERFLOW #655

merged 11 commits into from
Feb 13, 2025

Conversation

kareefardi
Copy link
Collaborator

@kareefardi kareefardi commented Feb 6, 2025 •
edited
Loading

@openlane-bot
Copy link
Collaborator

openlane-bot commented Feb 6, 2025 •
edited
Loading

Failed to create report:

Metrics not found for commit: 2473cd0ec63fa50fda29ea3f72bd303dca1b4dc2.

@kareefardi
update changelog and add test a default value of 1
5537d65 
Signed-off-by: Kareem Farid <[email protected]>
@kareefardi
format
1d8e405 
Signed-off-by: Kareem Farid <[email protected]>
@kareefardi
test value 0.5
702b15f 
Signed-off-by: Kareem Farid <[email protected]>
@kareefardi
make it optional
ee39705 
Signed-off-by: Kareem Farid <[email protected]>
@kareefardi kareefardi marked this pull request as ready for review February 10, 2025 12:10
@kareefardi kareefardi requested a review from donn February 10, 2025 12:10
@kareefardi
Copy link
Collaborator Author

kareefardi commented Feb 10, 2025 •
edited
Loading

TODO: add design that triggered the addition of the PR
Design added.

donn
donn reviewed Feb 12, 2025
View reviewed changes
openlane/steps/openroad.py Outdated Show resolved Hide resolved
@donn donn merged commit 2473cd0 into dev Feb 13, 2025
4 of 7 checks passed
@donn donn deleted the keep_resize_below_overflow branch February 13, 2025 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@donn donn donn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kareefardi @openlane-bot @donn