Get traceparent from environment when running in controller env #125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we are running in the controller environment we don't use the environment provider as a library and won't automatically get the trace parent from the suite runner. We now assume that the ETOS controller will pass the traceparent to the environment provider job as an environment variable and load it. This will mean that there's a slight difference in the trace produced from the controller environment vs the v0 environment, but I don't see a big problem with that since the controller environment does do the environment checkout a bit differently and that will be reflected in the trace.
t-persson
requested review from
fredjn and
andmat900
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applicable Issues
Found no issue
Description of the Change
When we are running in the controller environment we don't use the environment provider as a library and won't automatically get the trace parent from the suite runner.
We now assume that the ETOS controller will pass the traceparent to the environment provider job as an environment variable and load it.
Alternate Designs
We could've created a new span for the v0 environment as well, but I don't want to change the trace for v0 at this moment.
Possible Drawbacks
This will mean that there's a slight difference in the trace produced from the controller environment vs the v0 environment, but I don't see a big problem with that since the controller environment does do the environment checkout a bit differently and that will be reflected in the trace.
Sign-off
Developer's Certificate of Origin 1.1
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or
(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or
(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.
(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.
Signed-off-by: Tobias Persson [email protected]