Skip to content

ESQL: Mute only dense vector tests #130089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

alex-spies
Copy link
Contributor

Relates #130085

The dense_vector dataset started acting up in 9.1->9.0 bwc tests. Let's skip the corresponding dataset whose index failed to be created in the tests.

@alex-spies alex-spies added >test Issues or PRs that are addressing/adding tests :Analytics/ES|QL AKA ESQL v9.2.0 labels Jun 26, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

@elasticsearchmachine elasticsearchmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Jun 26, 2025
Copy link
Contributor

@craigtaverner craigtaverner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Muting just dense_vector seems much better than muting the entire test class.

Copy link
Contributor

@ivancea ivancea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. However, would it make more sense to mute them in muted-tests instead (With the method param, of course)? As to have everything centralized there

Edit: Nevermind, it's a dataset issue

@alex-spies alex-spies added auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) labels Jun 26, 2025
@alex-spies alex-spies removed the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Jun 26, 2025
@alex-spies
Copy link
Contributor Author

Seems like @afoucret found a better approach in #130090. Closing

@alex-spies alex-spies closed this Jun 26, 2025
@jimczi
Copy link
Contributor

jimczi commented Jul 3, 2025

Quick drive-by note: sidestepping a bug isn’t quite the same as fixing it. Let’s make sure we leave the issue with a proper reproduction next time, this one’s a real bug: #130540

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/ES|QL AKA ESQL Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) >test Issues or PRs that are addressing/adding tests v9.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants