Skip to content

[ES|QL] Fix mapping for the colors CSV dataset (failing bwc tests) #130090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 26, 2025

Conversation

afoucret
Copy link
Contributor

@afoucret afoucret commented Jun 26, 2025

Fix #130085

@afoucret afoucret added >test Issues or PRs that are addressing/adding tests :Analytics/ES|QL AKA ESQL v9.1.0 labels Jun 26, 2025
@elasticsearchmachine elasticsearchmachine added Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) v9.2.0 labels Jun 26, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

Copy link
Contributor

@alex-spies alex-spies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The mapping fix looks okay, thank you!

@alex-spies
Copy link
Contributor

alex-spies commented Jun 26, 2025

Also note that, this can't fix #128224. That was on 8.19. I have not seen similar issues with the colors dataset on 9.x. Although getting the mappings aligned doesn't hurt, either way.

@@ -5,7 +5,12 @@
},
"vector": {
"type": "dense_vector",
"similarity": "l2_norm"
"similarity": "l2_norm",
"index_options": {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ℹ️ @alex-spies It seems that adding explicit index_options is preventing the failure

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooh, great, thank you!

Copy link
Contributor

@alex-spies alex-spies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks @afoucret !

@afoucret afoucret enabled auto-merge (squash) June 26, 2025 11:00
@alex-spies alex-spies added the auto-backport Automatically create backport pull requests when merged label Jun 26, 2025
@afoucret afoucret merged commit e2dfd5d into elastic:main Jun 26, 2025
32 checks passed
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

The backport operation could not be completed due to the following error:

There are no branches to backport to. Aborting.

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 130090

afoucret added a commit to afoucret/elasticsearch that referenced this pull request Jun 27, 2025
…ng bwc tests) (elastic#130090)

(cherry picked from commit e2dfd5d)

# Conflicts:
#	muted-tests.yml
@afoucret
Copy link
Contributor Author

💚 All backports created successfully

Status Branch Result
9.1

Questions ?

Please refer to the Backport tool documentation

elasticsearchmachine pushed a commit that referenced this pull request Jun 27, 2025
…ng bwc tests) (#130090) (#130164)

(cherry picked from commit e2dfd5d)

# Conflicts:
#	muted-tests.yml
smalyshev pushed a commit to smalyshev/elasticsearch that referenced this pull request Jun 27, 2025
mridula-s109 pushed a commit to mridula-s109/elasticsearch that referenced this pull request Jul 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/ES|QL AKA ESQL auto-backport Automatically create backport pull requests when merged backport pending Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) >test Issues or PRs that are addressing/adding tests v9.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] MixedClusterEsqlSpecIT failling on main->9.0 bwc tests
3 participants