-
Notifications
You must be signed in to change notification settings - Fork 25.3k
[ES|QL] Fix mapping for the colors CSV dataset (failing bwc tests) #130090
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Pinging @elastic/es-analytical-engine (Team:Analytics) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The mapping fix looks okay, thank you!
...l/src/main/java/org/elasticsearch/xpack/esql/inference/embedding/DenseEmbeddingOperator.java
Outdated
Show resolved
Hide resolved
Also note that, this can't fix #128224. That was on 8.19. I have not seen similar issues with the |
@@ -5,7 +5,12 @@ | |||
}, | |||
"vector": { | |||
"type": "dense_vector", | |||
"similarity": "l2_norm" | |||
"similarity": "l2_norm", | |||
"index_options": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ℹ️ @alex-spies It seems that adding explicit index_options is preventing the failure
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ooh, great, thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks @afoucret !
💔 Backport failedThe backport operation could not be completed due to the following error:
You can use sqren/backport to manually backport by running |
…ng bwc tests) (elastic#130090) (cherry picked from commit e2dfd5d) # Conflicts: # muted-tests.yml
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
Fix #130085