-
Notifications
You must be signed in to change notification settings - Fork 451
gcp: remove never-successful violation field renames #13777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
efd6
wants to merge
2
commits into
elastic:main
Choose a base branch
from
efd6:gcp_audit_renames
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The rename refers to fields that do not exist in the type, and appears to have been incorrectly added to the block handling PolicyViolationInfo. The alternative would have been to add the following, but we already document the current behaviour, so leaving this as is as unfortunate. - foreach: field: gcp.audit.policy_violation_info.violations ignore_missing: true ignore_failure: true processor: rename: field: _ingest._value.errorMessage target_field: _ingest._value.error_message if: ctx.gcp?.audit?.policy_violation_info?.violations instanceof List - foreach: field: gcp.audit.policy_violation_info.violations ignore_missing: true ignore_failure: true processor: rename: field: _ingest._value.checkedValue target_field: _ingest._value.checked_value if: ctx.gcp?.audit?.policy_violation_info?.violations instanceof List - foreach: field: gcp.audit.policy_violation_info.violations ignore_missing: true ignore_failure: true processor: rename: field: _ingest._value.policyType target_field: _ingest._value.policy_type if: ctx.gcp?.audit?.policy_violation_info?.violations instanceof List [1]https://cloud.google.com/logging/docs/reference/audit/auditlog/rest/Shared.Types/AuditLog#ViolationInfo
🚀 Benchmarks reportTo see the full report comment with |
💚 Build Succeeded
cc @efd6 |
|
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bugfix
Pull request that fixes a bug issue
Integration:gcp
Google Cloud Platform
Team:Security-Service Integrations
Security Service Integrations team [elastic/security-service-integrations]
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Thanks to @ishleenk17 for identifying this.
Checklist
changelog.yml
file.Author's Checklist
How to test this PR locally
Related issues
Screenshots