Skip to content

gcp: remove never-successful violation field renames #13777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+36 −40
Open

gcp: remove never-successful violation field renames #13777

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4fd68fc
regenerate test expectations
efd6 May 4, 2025
2050049
gcp: remove never-successful violation field renames
efd6 May 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/gcp/changelog.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,9 @@
# newer versions go on top
- version: "2.41.2"
changes:
- description: Remove redundant audit violation field renames.
type: bugfix
link: https://github.com/elastic/integrations/pull/13777
- version: "2.41.1"
changes:
- description: Preserve original value of resource name.
Expand Down
16 changes: 8 additions & 8 deletions ...tream/audit/_dev/test/pipeline/test-cloudresourcemanager-googleapis-com.log-expected.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,14 @@
"expected": [
{
"@timestamp": "2024-11-19T13:12:20.942Z",
"actor": {
"entity": {
"id": [
"serviceAccount:[email protected]",
"[email protected]"
]
}
},
"client": {
"user": {
"email": "[email protected]",
Expand Down Expand Up @@ -139,14 +147,6 @@
"level": "NOTICE",
"logger": "projects/project-id/logs/cloudaudit.googleapis.com%2Factivity"
},
"actor": {
"entity": {
"id": [
"serviceAccount:[email protected]",
"[email protected]"
]
}
},
"related": {
"entity": [
"projects/project-id/roles/x",
Expand Down
16 changes: 8 additions & 8 deletions ...es/gcp/data_stream/audit/_dev/test/pipeline/test-compute-googleapis-com.log-expected.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,14 @@
"expected": [
{
"@timestamp": "2024-11-19T13:13:13.176Z",
"actor": {
"entity": {
"id": [
"serviceAccount:[email protected]",
"[email protected]"
]
}
},
"client": {
"user": {
"email": "[email protected]",
Expand Down Expand Up @@ -206,14 +214,6 @@
"level": "NOTICE",
"logger": "projects/project-id/logs/cloudaudit.googleapis.com%2Factivity"
},
"actor": {
"entity": {
"id": [
"serviceAccount:[email protected]",
"[email protected]"
]
}
},
"related": {
"entity": [
"https://www.googleapis.com/compute/v1/projects/project-id/global/networks/x-logs-network",
Expand Down
14 changes: 7 additions & 7 deletions ...data_stream/audit/_dev/test/pipeline/test-iamcredentials-googleapis-com.log-expected.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,13 @@
"expected": [
{
"@timestamp": "2024-11-19T00:49:55.293Z",
"actor": {
"entity": {
"id": [
"principal://iam.googleapis.com/projects/project-id/locations/global/workloadIdentityPools/..."
]
}
},
"client": {
"user": {
"id": "principal://iam.googleapis.com/projects/project-id/locations/global/workloadIdentityPools/..."
Expand Down Expand Up @@ -61,13 +68,6 @@
"level": "INFO",
"logger": "projects/project-id/logs/cloudaudit.googleapis.com%2Fdata_access"
},
"actor": {
"entity": {
"id": [
"principal://iam.googleapis.com/projects/project-id/locations/global/workloadIdentityPools/..."
]
}
},
"related": {
"entity": [
"projects/-/serviceAccounts/[email protected]",
Expand Down
14 changes: 7 additions & 7 deletions packages/gcp/data_stream/audit/_dev/test/pipeline/test-sdh-3695.log-expected.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,13 @@
"expected": [
{
"@timestamp": "2023-08-02T11:20:30.734Z",
"actor": {
"entity": {
"id": [
"[email protected]"
]
}
},
"client": {
"user": {
"email": "[email protected]"
Expand Down Expand Up @@ -39,13 +46,6 @@
"level": "INFO",
"logger": "organizations/123456789098/logs/cloudaudit.googleapis.com%2Fdata_access"
},
"actor": {
"entity": {
"id": [
"[email protected]"
]
}
},
"related": {
"entity": [
"organizations/123456789098",
Expand Down
9 changes: 0 additions & 9 deletions packages/gcp/data_stream/audit/elasticsearch/ingest_pipeline/default.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -413,15 +413,6 @@ processors:
field: gcp.audit.policy_violation_info.violations
copy_from: json.protoPayload.policyViolationInfo.orgPolicyViolationInfo.violationInfo
ignore_failure: true
- foreach:
field: gcp.audit.policy_violation_info.violations
ignore_missing: true
ignore_failure: true
processor:
rename:
field: _ingest._value.resourceAttributes
target_field: _ingest._value.resource_attributes
if: ctx.gcp?.audit?.policy_violation_info instanceof List
- rename:
field: json.protoPayload.policyViolationInfo.orgPolicyViolationInfo.payload
target_field: gcp.audit.policy_violation_info.payload
Expand Down
2 changes: 1 addition & 1 deletion packages/gcp/manifest.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: gcp
title: Google Cloud Platform
version: "2.41.1"
version: "2.41.2"
description: Collect logs and metrics from Google Cloud Platform with Elastic Agent.
type: integration
icons:
Expand Down